Gutenberg: Theme name in Template Selector

Created on 26 Feb 2020  Â·  16Comments  Â·  Source: WordPress/gutenberg

It'd be good to display the current theme name in the template selector of edit-site.

image

Needs Dev [Feature] Full Site Editing [Status] In Progress

Most helpful comment

Building on the work from #20470, here's the latest on the theme info (shown in its :hover state):

image

All 16 comments

At the bare minimum, I could see adding a section to the bottom of the menu to display the theme name...

image

...but I'm not entirely sure what purpose this serves. Maybe we can add a preview on hover, and some other options to view the theme details and view all themes:

Template Menu with Theme

The "Theme details" item probably isn't necessary — selecting the theme name could open the details like we do now in the Themes screen in wp-admin:

image

I'm not sure if we can use that exact modal within the editor, but I could see adapting that UI. We could look to add more template-related information about the theme here as well.

It'd be good to display the current theme name in the template selector of edit-site.

@mtias I'm still curious as to why. I'm not sure exactly what purpose this would serve.

Right now you cannot tell while in edit site view which theme you have enabled. The templates and template parts come from a mixture of site content (user modified) and theme content. It's important to trace where those are coming from.

Right now you cannot tell while in edit site view which theme you have enabled. The templates and template parts come from a mixture of site content (user modified) and theme content. It's important to trace where those are coming from.

@mtias Right. Perhaps we can delineate which templates are coming from the theme and show the theme name in conjunction with the template? Perhaps when previewing the template?

That's somewhat already in place — all templates come from the theme unless they have the "modified by user" dot as explained here https://github.com/WordPress/gutenberg/issues/19269

image

@mtias And templates couldn't be added by other sources like plugins?

Building on the work from #20470, here's the latest on the theme info (shown in its :hover state):

image

This hover experience from @shaunandrews communicating the theme visually works really well. I noted that if this hover+preview is used here, it would be great to see it used for the templates in this issue: https://github.com/WordPress/gutenberg/issues/20476

What would show where the theme is, if the template is not part of the theme, but only exists as a wp_template post_type?

@shaunandrews Does this still need design feedback or has a final direction already been decided upon? If so, can you please provide some updated visuals and links to the Figma source files?

@joanrho This works for now and fits with the template previews. Moving to Needs dev.

Does this still need design feedback or has a final direction already been decided upon?

This seems like a mostly straight-foward one, I have nothing more to add design-wise at this point.

Figma file is here: https://www.figma.com/file/TR15iRvk7toGHnKb68QN1K/Full-Site-Editing?node-id=1060%3A0

@MichaelArestad @shaunandrews Any thoughts on this? https://github.com/WordPress/gutenberg/issues/20469#issuecomment-603445859

I also feel like this comment is worth addressing as well:
https://github.com/WordPress/gutenberg/issues/20469#issuecomment-597730143

What would show where the theme is, if the template is not part of the theme, but only exists as a wp_template post_type?

I would expect nothing to show there. Perhaps, if the template is added by a plugin, it could show the plugin name in place of the theme.

I came here via #19252. Going to give this a stab.

Was this page helpful?
0 / 5 - 0 ratings