Gutenberg: Changing navigation link doesn't update the label

[draganescu]

Describe the bug
When changing the link of a navigation menu item to a post or page the label of the link does not update to the one of the selected post or page.

To reproduce

1. Make a post
2. Add an empty navigation menu
3. Add a navigation item by searching for a page
4. Observe the label
5. Click on edit link button and then on change
6. Search for a different page
7. Select it
8. Observe the label: bug.

Expected behavior
The new selected page or post should be reflected by a new label.

Screenshots

[retrofox]

Although I think you're right, I'm not 100% sure that this behavior wasn't to desired. AFAIK, the link label is populated from the page title only if it is not defined. Guessing it was the intended behavior in order to keep the previous label, that btw may be defined explicitly b the user.

[melchoyce]

My first instinct is “that’s a bug.” If I’d manually changed the label, I’d see maybe keeping it.
But if I add and then replace without manually editing the label, I expect it to totally replace the previous menu item.

[karmatosed]

I also feel like this is a bug when experiencing it so it might be worth fixing as a result.