Gutenberg: Links can be added to the Button Block's text using the shortcut

[talldan]

Describe the bug
The button block has its own UI for adding links. However, a user can also highlight the text in the button when editing a button block and use Cmd+K or Ctrl+K to add link formatting to button text.

This duplication is confusing.

To reproduce
Steps to reproduce the behavior:

1. Create a new post
2. Add a button block
3. Type some text in the button
4. Highlight the text in the button
5. Use the Cmd+K (Mac) or Ctrl+K (Windows/Linux) keyboard shortcut
6. Observe that link formatting can be applied to the button's text.

Expected behavior
The link format should be disabled on the button block as it has its own interface for adding links.

Screenshots

Additional context
Discovered while testing #10128

[epiqueras]

This line:

https://github.com/WordPress/gutenberg/blob/5cb8b8f3a025e4ecf24b9b3ec31988b2c7b02d5c/packages/block-library/src/button/edit.js#L81

excludes the "link" rich text format from the toolbar (and hotkeys?), but it doesn't seem to be doing anything.

cc @ellatrix

[chrisvanpatten]

I’ve noticed this as well - it seems like the behaviour around which controls are visible does not impact all keyboard shortcuts.

[chrisvanpatten]

(Also worth noting that the formats in the drop down are visible even though they aren’t explicitly enabled in formattingControls.)

[ellatrix]

Should be fixed by #14542.