Gutenberg: Exit Code Editor button is hidden when notices show up

Created on 13 Nov 2018  路  2Comments  路  Source: WordPress/gutenberg

Describe the bug
Exit Code Editor button is hidden when notices show up. This bug occurs only in desktop.

To Reproduce
Steps to reproduce the behavior:

  1. Switch to Code Editor.
  2. Make some change and update.
  3. The notice show up and Exit Code Editor button get hidden.

Expected behavior
Exit Code Editor button always visible while Code Editor mode is enabled.

Screenshots
Desktop:
desktop

Mobile (works as expected):
mobile

Desktop (please complete the following information):

  • OS: Fedora 29
  • Browser Chrome
  • Version 70
[Feature] Code Editor [Package] Notices

Most helpful comment

I think it would be good to have a similar treatment to pushing down content in the code editor as @jasmussen had previously implemented for the visual editor in #13614.

This is already implemented but not for all the notices. I think once the more temporary notices become snackbar notices, this could be considered to be applied to all the remaining notices.

All 2 comments

@youknowriad While I think it's fair to say that #15594 would resolve this as far as the immediate issue of the save confirmation blocking the button, it would still remain an issue for any other notice which occupies this space.

I think it would be good to have a similar treatment to pushing down content in the code editor as @jasmussen had previously implemented for the visual editor in #13614.

I think it would be good to have a similar treatment to pushing down content in the code editor as @jasmussen had previously implemented for the visual editor in #13614.

This is already implemented but not for all the notices. I think once the more temporary notices become snackbar notices, this could be considered to be applied to all the remaining notices.

Was this page helpful?
0 / 5 - 0 ratings