Gutenberg: Consider to improve consistency of the button labels and styles

[afercia]

Please see below, a quick comparison between the post permalink buttons and the shared block button. Initially, the both display an "Edit" button with the same style:

Instead, when editing:

• the first button becomes "OK" and is styled like a default button
• the second button becomes "Save" and is styled like a primary button (I understand it's to differentiate it from the "Cancel" button)

A few considerations:

• what is the standard text for a save action in Gutenberg? "OK" or "Save"? Seems to me using always the same text would improve consistency and make things easier for users
• should the "OK" button be styled as a primary button?
• what is the standard for a save button, should it always be paired with a "Cancel" button?

/Cc @karmatosed

[karmatosed]

Good catch, I am always up for unifying where we can.

I would be totally up for having 'save' over 'ok' on both and remove cancel. Unless there are accessibility reasons to have also a cancel? If we removed 'cancel' we'd need to catch the 'not in input' as meaning not editing same as we have for permalinks.

[afercia]

Yeah, "Save" seems more appropriate to me too. No particular a11y reasons for the "Cancel" button I can think of: pressing Escape already closes the edit form. Yep it would need to close also when "clicking outside".

Should the primary style be removed? I guess so?

[karmatosed]

@afercia thanks and yes I agree it's not a primary action so removing that style makes sense.

[folletto]

Yeah, "Save" seems more appropriate to me too.

+1

[mtias]

@karmatosed can we make an actionable issue out of this?

[karmatosed]

Yes we are working on #7593 and close to a solution.