Gutenberg: Classic editor: "toggle toolbar" keyboard shortcut JS TypeError

[afercia]

To reproduce:

• add a Classic block
• click the editable area
• on a mac: press Control-Option-Z to toggle the TinyMCE second toolbar
• Uncaught TypeError: Cannot read property 'firstChild' of undefined

As far as I see, this is because the WordPress script src/wp-includes/js/tinymce/plugins/wordpress/plugin.js expects an iframe which doesn't exist in Gutenberg.

I'm not sure the WordPress plugins script can be used "as is" in Gutenberg without a thorough check of what it does and how that behaves in Gutenberg, see for example #6195 . /Cc @azaozz @iseulde

Aside:
why this button in Gutenberg is named "More" while traditionally it has always been named "Toolbar Toggle"? I'd be all for improving the original name but for consistency Gutenberg and the old editor should use the same name.

[designsimply]

Tested and confirmed that pressing Control-Option-Z with the content area focused for a classic block doesn't toggle the more menu as expected.

TypeError: undefined is not an object (evaluating 'b.getContentAreaContainer().firstChild')
plugin.min.js:1:452

Additional info: I also noticed that once Control-Option-Z has been pressed, I can no longer click the "More" or "Toggle Toolbar" button in the classic block toolbar to trigger the 2nd row of options. (32s)

^{Tested with Safari 11.1.2 on macOS 10.13.6.}

[tofumatt]

Note that Control-Option-Z now removes a block and that shortcut was removed from the Classic Block:

So it seems this is no longer an issue.

[azaozz]

Hm, removing it would better be handled in the wordpress TinyMCE plugin in core (it throws errors atm). Will add it there.

[afercia]

Yep Uncaught TypeError: Cannot read property 'firstChild' of undefined is still there, even if the shortcut now removes the block. Additionally, I see also a new error (testing in Chrome):
Uncaught TypeError: Cannot read property 'getRng' of null

guessing it's something still related to TinyMCE which tries to get the editor selection (wptextpattern TinyMCE plugin?)

[afercia]

@tofumatt I'd suggest to reopen this, at least to track the issue, as releasing software that throws 2 JS TypeErrors seems not so ideal to me.

[tofumatt]

Ah, I see. @azaozz: is there a Trac issue where this is tracked or should we reopen the issue here?

[azaozz]

@tofumatt no need to reopen, already committed to core. The error should disappear after svn up :)