Gutenberg: Toolbar Covers Admin Notices

[bmoredrew]

Issue Overview

In Gutenberg 1.6.1 the toolbar blocks admin notices, positioning fails to let user click, uncover or dismiss.

Steps to Reproduce

1. Have an active admin notice
2. Create and/or Edit a Post

Screenshot

Sidebar open:

Sidebar closed:

[hedgefield]

Yep, this has been an issue for a long time. Should we hide these notices in the editor, or move the UI down to make room for them? _Personally_ I wouldn't prefer the latter, so I'm interested to hear what people's feelings are on this.

[darrencoutts118]

I would move them down. Developers will likely want to be able to add notices, and this would be more consistent

[maddisondesigns]

Don't ever hide notices (as annoying as they can be). Notices are part of WordPress core and Gutenberg needs to accommodate them, not simply hide them or ignore them because you've change the ui.

[youknowriad]

Later, we should think about building enhancing the "notifications" API (icon in the top bar, unread notifications...) Something like WP.com. But this is out of the scope of Gutenberg.

[maddisondesigns]

Agreed! WP desperately needs a better system for managing notifications! To many plugins show their own style notifications, and/or useless notifications, when they update.

[jeherve]

This looks like a duplicate of #3214

[jsmoriss]

Moving the notices down makes no difference - the actual layout of the page is the problem.

Here's an example from a truly screwed up page. lol. :)

js.

[wpmark]

I have just noticed this is a problem with the VaultPress plugin admin notices. This is how the notice shows on the dashboard screen:

And this is how it shows on the editing screen:

Not ideal.

[nagpai]

Looks like notifications that appear below the admin page title - eg- "Dashboard" appear to overlap in the Gutenberg page.

Steps i did.

1. Created a test site
2. Install and activate plugins - Gutenberg, WordFence, WooCommerce Stripe payment gateway (without installing WooCommerce), to generate notifications.

I see this:

1. Switch to Posts >> Add Post (wiith Gutenberg). We see only the Stripe Payment Gateway Plugin notifications overlapping the editor. The WordFence notification that appears above the title is not visible in the overlap. If i disable the Stripe plugin, we do not see anything overlapping.

[edwinsnotje]

Notifications can be relevant while editing a post.

Some plugins show irrelevant or nagging notifications. However, that is no reason to end notifications, just as it is no reason to end plugins. There can be usefull notifications concerning a post, or concerning some meta-post website-condition.

It would furthermore be nice to have notifications outside the editor, as we have now, and notifications inside the new toolbar, depending on the editing context.

[kmgalanakis]

If you ask me, all the admin notices should go inside the div with class components-notice-list and the position of it should not be fixed.

[jasmussen]

This has been addressed as part of #4811, which hides the notices in the editor. Notices are shown everywhere else in the admin, that is unchanged.

There is also a native interface for showing notices to the editor.

[maddisondesigns]

You're seriously just going to hide them!? That's a horrible idea! Gutenberg needs to accommodate core functionality, not just hide things when you feel like it or because it interfere's with your new design. You need to change your UI to accommodate them if need be.

[jasmussen]

This is the path forward we are looking at for now. Tickets can be reopened, patches can be reverted. But it's important, especially while we are in beta, to keep moving. In this case, the reasoning for hiding notices to provide a better API for notices in the new editor, where you won't end up with undismissable notices.

In other words, these notices aren't hidden because you should never see notices in the editor, it's because there is no good path to changing notices that can consist of arbitrary HTML into something that the editor can provide a good interface for.

Given that you still see these notices in every other screen in the admin, we decided to move ahead. But as with all things, we can move backwards again.

[maddisondesigns]

So, now there's one way to display notices in the editor, and a completely different way to show notices elsewhere? That's ridiculous. If there's an issue with displaying notices in the editor, and the problem is due to the existing WP notification system (or lack thereof), then fix how notices work in core.

As per my comment above (back in Nov), I think everyone can agree that WP desperately needs a better notification system. Get it fixed in core so Gutenberg can make use of it. Don't just hide the problem.

[jasmussen]

If there's an issue with displaying notices in the editor, and the problem is due to the existing WP notification system (or lack thereof), then fix how notices work in core.

I think that would be ideal. See also https://github.com/WordPress/gutenberg/issues/3395#issuecomment-344181166

[karmatosed]

@maddisondesigns please be civil in way you approach this, passion is one thing but we are all working on a solution together and that takes respectful communication. Whilst we can work to make things better we can't solve all of core's issues in Gutenberg, that will happen over time.

I do not think anyone will argue against having a better notification system, it's how that happens and it needs someone like you who is passionate about this area to in core help find a solution. I'd be very keen to see a feature plugin for notifications and messages worked on outside of Gutenberg and fully support that as a project.