Gutenberg-mobile: [Bottom Sheets] Tapping "return" should dismiss sheet

[iamthomasbishop]

Expected

When I'm editing something on a bottom sheet, I expect tapping "return" to dismiss the sheet.

Actual

Tapping return dismisses the keyboard, but not the sheet with it.

[guarani]

Current Situation

After making this change (to make tapping "return" dismiss the bottom sheet), we noticed a difference in keyboard behavior and decided to align Android with iOS' current behavior. Changes need to be made on Android to make the keyboard reappear and focus to return to the current block, once the bottom sheet is dismissed.

Side note: When the return button is pressed on an empty link field, the keyboard on Android behaves correctly – it's only when a link is added that the keyboard does not reappear.

Proposal

After debugging this, the problem could be in the Aztec native code where something may be blocking the keyboard from reappearing.
Since this could take significant time to fix, I'm proposing moving forward with the current PR and leaving the difference in keyboard behavior – which seems low priority – out of scope here.

Thoughts @iamthomasbishop?

[iamthomasbishop]

Since this could take significant time to fix, I'm proposing moving forward with the current PR and leaving the difference in keyboard behavior – which seems low priority – out of scope here.

I think that makes sense 👍

[mchowning]

Since this could take significant time to fix, I'm proposing moving forward with the current PR and leaving the difference in keyboard behavior – which seems low priority – out of scope here.

:wave: @guarani and @iamthomasbishop ! Merging the PR automatically closed this issue. Do we want to track the Android keyboard close behavior (either by keeping this issue open or as a separate issue)?

[guarani]

I'd say it seems like a very minor issue to me, but I also understand it's good to align the platforms where possible.
I can modify the PR to use the "Addresses" keyword instead of "Fixes", so that this issue is not closed for now and we can merge the PR.

[mchowning]

I'd say it seems like a very minor issue to me, but I also understand it's good to align the platforms where possible.

I don't feel strongly, I just wanted to make sure it didn't slip through the cracks by accident. What do you think @iamthomasbishop—should we track the issue where the Android keyboard is dismissed after hitting enter to set a link?

I can modify the PR to use the "Addresses" keyword instead of "Fixes", so that this issue is not closed for now and we can merge the PR.

The issue was already closed when the Gutenberg PR got merged because it referenced the issue.