Gutenberg-mobile: Paragraph block is prematurely removed on backspace event

Created on 3 Apr 2019  路  8Comments  路  Source: wordpress-mobile/gutenberg-mobile

When all text is deleted from a paragraph, the block is removed prematurely. This issue has been encountered on Android Emulator, but may not occur on a physical device.

Steps to reproduce:

  • Place caret at the end of the "Hello World!" paragraph (after the '!')
  • Press [backspace] 12 times

Expected result:
The (empty) paragraph block remains focused, with the placeholder text ("Start writing...") visible.

Actual Result:
The paragraph block is removed. The focus changes to the previous block.

This behavior is mentioned in #699, and may be related to #783.

Screencast:

Writing Flow [Type] Bug [Type] Crash
Source
picture mkevins

All 8 comments

I can confirm this happens on WPAndroid alpha-160

koke picture koke on 3 Apr 2019
👍1

I've seen a crash that seems related:

  1. Create a new post
  2. Tap the link button and enter some url and text
  3. Close the link UI
  4. Press backspace enough times to delete the whole link
  5. Crash

I've seen it happen with other combinations of typing and links, but this were steps where I could reproduce consistently.

Tested on WPAndroid alpha-160

koke picture koke on 4 Apr 2019
👀1

Hey @mkevins, thanks for the feedback!

Behavior from this issue is fixed in this PR: https://github.com/wordpress-mobile/gutenberg-mobile/pull/756 as part of this issue: https://github.com/wordpress-mobile/gutenberg-mobile/issues/699

I will add you as a reviewer in the PR so that you can check if everything is working alright.

marecar3 picture marecar3 on 4 Apr 2019
👀1

So is it fine to close this as a duplicate of #699?

koke picture koke on 4 Apr 2019
👍1

Closing this one in favor of #699

marecar3 picture marecar3 on 4 Apr 2019

Hey @mkevins, thanks for the feedback!

Behavior from this issue is fixed in this PR: #756 as part of this issue: #699

I will add you as a reviewer in the PR so that you can check if everything is working alright.

Thanks @marecar3 ! I wasn't 馃挴 sure if the two issues would be solved by the same PR, so I split out this issue. Glad that the PR solves both! I'll test it out.

mkevins picture mkevins on 5 Apr 2019
👍1

I just tested it (on the Android emulator), and it indeed solves the problem. Thank you!

mkevins picture mkevins on 5 Apr 2019
👍1

Thanks @mkevins !

marecar3 picture marecar3 on 5 Apr 2019
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

etoledom picture etoledom  路  4Comments
alextheberge picture alextheberge  路  4Comments
mkevins picture mkevins  路  3Comments
designsimply picture designsimply  路  3Comments
iamthomasbishop picture iamthomasbishop  路  3Comments