Gt-new-horizons-modpack: Lapis and diamond veins are incredibly rare/nonexistant

[Bluebine]

Which modpack version are you using?

2.0.2.5 TEST version
#

If in multiplayer; On which server does this happen?

SP
#

What did you try to do, and what did you expect to happen?

I looked for lapis and diamonds, the two overworld veins I haven't found yet.
#

What happend instead? (Attach screenshots if needed)

I explored this ENTIRE area on the map, with a prospector's scanner so I wouldn't miss anything, and didn't find a SINGLE vein of diamond or lapis.

#

What do you suggest instead/what changes do you propose?

Make lapis and diamond ore more common, or make them spawn if they don't, I'm not sure which is the issue.

[Dream-Master]

No they not but if you found one you can search around and found another very close.
Try to create a new world and use the Orscanner to see how veins looks like.

[Dream-Master]

diamond veins more rare then lapis

[Dream-Master]

If i change one mix all other will chang too. @richardhendricks Was the oremixes before your code change ignore configs?

[richardhendricks]

Diamond has a 2.6% base chance in a filled orevein. Looks like you searched about 30 spots and found ore? Chance of finding diamond after 30 spots is 1-(1-.026)^30, or about 55%. Not surprising you haven't found any yet.

https://docs.google.com/spreadsheets/d/18bCPP7Ul9CMtTXsVwQvEeZCAzrR7OLzizMnwJfvRzx0/htmlview

[richardhendricks]

Sorry, you said you explored the entire area with a prospectors scanner? Can you post a screen shot?

[Dream-Master]

i can make screenshots if you want. I found 2 or 3 lapis veins in a 500x500 radius.

[richardhendricks]

@Bluebine Please provide worldseed for your SP game and I will do an orevein search.

[richardhendricks]

Screenshots aren't necessary, I'm going to do a couple of test runs with debug enabled and just make a spreadsheet

[richardhendricks]

orevein_sampling_sorted.txt

Maybe there is something going on. It seems like at >5.2% expected, the actual is about 2.5x, and below 5.2% expected, the actual is about 1/2. Numbers are still suffering a little from the law of small numbers, but the skew high is pretty obvious. Height availability will skew results a little, but this is more than expected.

2001 ore seeds.  669 were skipped by design, so 669/(2670) = 25% empty, as expected.
Found  | Percentage| Expected | ore                  | notes
18     |     .89%  |  10.5%   | lignite              | Expected, lignite is only available at really high heights
248    |   12.4%   |   5.2%   | coal                 | Oddly high
50     |    2.5%   |  10.5%   | magnetite            | Expected, magnetite is only available at really high heights
495    |   24.7%   |  10.5%   | gold                 | Oddly high
227    |   11.3%   |   7.89%  | iron                 | Oddly high
13     |     .65%  |   3.2%   | cassiterite          | Expected, cassiterite is only available at really high heights
184    |    9.2%   |   5.2%   | copper               | Oddly high
104    |    5.2%   |   5.2%   | salts
115    |    5.75%  |   3.9%   | redstone
20     |    1.0%   |   2.6%   | soapstone
12     |     .60%  |   1.3%   | manganese
23     |    1.15%  |   2.6%   | diamond              |
34     |    1.7%   |    3.9   | apatite              |
26     |    1.3%   |   2.6%   | lapis
209    |   10.5%   |   5.2%   | custom.06(min sands) | Oddly high
169    |    8.44%  |   5.2%   | custom.07(garnet/tin)| Oddly high
23     |    1.15%  |   3.9%   | custom.08(kaolinite) | 
14     |     .70%  |   1.3%   | custom.09(mica)      |
17     |     .85%  |   2.6%   | oilsands

[richardhendricks]

Second worldseed, similar bias.

Found |  Percentage | Expected  | ore                  | notes
  13  |     0.92%   |   10.50%  | lignite              | Expected, lignite is only available at really high heights
 173  |    12.21%   |    5.20%  | coal                 | Oddly high
  33  |     2.33%   |   10.50%  | magnetite            | Expected, magnetite is only available at really high heights
 326  |    23.01%   |   10.50%  | gold                 | Oddly high
 176  |    12.42%   |    7.89%  | iron                 | Oddly high
   8  |     0.56%   |    3.20%  | cassiterite          | Expected, cassiterite is only available at really high heights
 117  |     8.26%   |    5.20%  | copper                
  61  |     4.30%   |    5.20%  | salts 
  91  |     6.42%   |    3.90%  | redstone  
  22  |     1.55%   |    2.60%  | soapstone 
  13  |     0.92%   |    1.30%  | manganese 
  28  |     1.98%   |    2.60%  | diamond               
  27  |     1.91%   |    3.9%   | apatite               
  20  |     1.41%   |    2.60%  | lapis 
 133  |     9.39%   |    5.20%  | custom.06(min sands) | Oddly high
 124  |     8.75%   |    5.20%  | custom.07(garnet/tin)| Oddly high
  32  |     2.26%   |    3.90%  | custom.08(kaolinite)   
   7  |     0.49%   |    1.30%  | custom.09(mica)       
  13  |     0.92%   |    2.60%  | oilsands  

[richardhendricks]

Ok, seems to be inherent to Gregtech, similar effect on minimal dev pack

This is without RWG, so if anything there should be a bias towards low ores like diamonds because of oceans, but clearly something else is going on. Redstone is way high compared to diamond but they should both be most-likely to place due to being lower than most heights. redstone should be 50% more than diamonds, but it looks like 400-500%.

[richardhendricks]

Created new ticket on my profile so I can collect info without spamming everyone.

[richardhendricks]

Problem root caused, fix under evaluation.

[richardhendricks]

Okay, ratios look good now. Tested on a stripped modpack, will do full modpack testing tomorrow.

[richardhendricks]

OK, tested Overworld, Nether, Twilight forest, numbers look much better now.

Still need to test The End and Deep Dark. I think all other dimensions are handled by other code, and if new dimensions are added to GT spawning, should be good enough.

Note that iron in Nether and copper in Twilight Forest in the ore spreadsheet is incorrect, they do not spawn there.

Since the Twilight Forest average height is so low, many veins are skewed lower/higher than normally expected.

[richardhendricks]

Tested Deep Dark and the End (essentially almost zero ores due to tiny asteroids)

Everything looks good, PR filed.

Deep dark sample ore distribution