Grpc-web: API Proposal - Client Interceptors

Created on 9 May 2019  路  6Comments  路  Source: grpc/grpc-web

~gRPC-Web Client Interceptors~

Proposal move to https://github.com/grpc/grpc-web/pull/558
Previous description removed to avoid confusion

Most helpful comment

I think we can do it two phases: first we can get one PR here in this repo, then with enough review/revision, we can do one over at grpc/proposal for formality.

All 6 comments

@rogchap This is a great start! Thanks for making this big effort to get this feature started.

Community, and users of gRPC-Web: please also review this to see if you have any feedback to the API design. Many people have asked about this before. Now is the time to speak up.

This is amazing! Thanks for working on this!

I'll have a closer look at the proposed API next week, but it seems like this is a very good start.
In the meantime, it might be easier to have this as a PR so we can use the review feature to discuss specific parts of the proposal (proposals/interceptors.md?).

Yes, agreed. Having a PR with a .md file can facilitate discussion. We can do this similarly to other gRPC RFCs by making a PR in this repo: https://github.com/grpc/proposal/pulls. Node.JS, Python, PHP, Ruby, C# Interceptors proposal all graduated from there. So browser/web can be next.

Easily done; I have the .md file of my original write up on disk.

Wasn't sure where to submit to get the best visibility for the community; if the gRPC/proposal repo is the right one I'll submit a PR there

I think we can do it two phases: first we can get one PR here in this repo, then with enough review/revision, we can do one over at grpc/proposal for formality.

@stanley-cheung @Yannic Moving this to https://github.com/grpc/grpc-web/pull/558

Was this page helpful?
0 / 5 - 0 ratings

Related issues

henpanta picture henpanta  路  5Comments

developerlaoz picture developerlaoz  路  3Comments

graup picture graup  路  4Comments

barrymichaeldoyle picture barrymichaeldoyle  路  4Comments

peteringram0 picture peteringram0  路  5Comments