Grpc-go: Add a method for resolver to report error

Created on 23 May 2018 · 13Comments · Source: grpc/grpc-go

If a resolver could not resolve a name, there's currently no way to report error back to ClientConn, and RPCs on the ClientConn will fail with timeout.

This method allows resolver to report error to ClientConn, and failfast RPCs should fail with this error (or RPC errors that contain info from this error).

P2 Feature

Source

menghanl

👍8

Most helpful comment

This is PR #2951.

dfawley on 28 Aug 2019

❤2

All 13 comments

Can we get an update on the status/timeline of this? In #2785, @menghanl you said that this was being actively worked on.

peats-bond on 15 May 2019

The plan was to do this after #2732, because they both add features to resolver/balancer. But #2732 got delayed by discussion on some details.
This is not necessary blocked by that PR, I think we can do this first. I will try to put something together this week.

menghanl on 16 May 2019

🎉1

Perfect, thanks for the update!

peats-bond on 16 May 2019

@menghanl any update?

peats-bond on 3 Jun 2019

The changes are in #2831. It might need more discussion.
Please take a look and comment. Thanks!

menghanl on 3 Jun 2019

🎉1

This error handling logic in resolver gets complicated with service config. (e.g. What to do if we get an error fetching addresses, but get service config? Do we apply the service config or also drop it? What if we get addresses but failed for service config?). We may end up needing two errors.

This is still under discussion, we will send an update when there's a conclusion.

menghanl on 6 Jun 2019

👍1

Gentle ping :)

peats-bond on 31 Jul 2019

@dfawley is working on this now. The PR will support this and also errors for service config. The PR should be ready soon (within two weeks).

menghanl on 31 Jul 2019

🎉1

any updates would be great :shipit:. trying to estimate if this how much risk this is to our project.

jeffbean on 28 Aug 2019

This is PR #2951.

dfawley on 28 Aug 2019

❤2

This is PR #2951.

🤦‍♂ ty! I need more coffee.

jeffbean on 28 Aug 2019

This issue is labeled as requiring an update from the reporter, and no update has been received after 7 days. If no update is provided in the next 7 days, this issue will be automatically closed.