Group-income-simple: Re-vamp the "invite members" functionality

[mmbotelho]

_Note: I decided to create this issue to replace the issue #406 - I did this because the functionality changed significantly, and the problems originally discussed there no longer make sense._

Problem

Right now, there's 2 ways to add members to a group:

• When creating a group;
• On the group dashboard.

There are several problems with the way we are currently doing this:

• The user adding a new member needs to know their EXACT username - this can create a lot of friction;
• Having this step on the group creation makes it unnecessarily long and time-consuming;
• It's still not possible to create or vote on a proposal to add a new member;

Solution

Now, the user can only add members on the dashboard page. It is no longer possible to do so in the group creation flow (so this step should be removed from the group creation flow).

The mechanism to add new members is fundamentally different now - we no longer expect the user to know the username of the new member; instead, we provide them with a unique access link, that the other person can use as a "key" to join the group.

There are now 2 ways of joining a group:

• Without a voting process - this is true when the group has been created for less than 1 week AND/OR has less than 3 members. In this case there's one link that can be used by up to 60 people (during that first week; after that, the link should expire).
• With a voting process - when the group has more than 1 week and/or more than 3 members.

When a voting process is necessary, a proposal should be created (one for each member added) and only after it has been accepted, the access link is generated. Since we have the pull request #343 (Proposals / voting logic) still open, I will not consider that part of the work necessary to complete this card. So, in short, everything that happens after a proposal is created is not part of this card.

Check out the Figma mockups here https://www.figma.com/file/ZR0DRPhhUuHdJtf7PbGAM6tW/Group-Income?node-id=875%3A2

Let me know if you have any questions!

[taoeffect]

When a voting process is necessary, a proposal should be created (one for each member added) and only after it has been accepted, the access link is generated.

Yep! And I should add that generated links (when people are being invited via a proposal) are tied to the name of the person being invited, and the UI should somehow reflect this so that Bob's link is paired with Bob, and Susan's link is paired with Susan, so that Bob's link doesn't get sent to Susan. The UI should make it very clear, in other words, who each invite link belongs to, so the wrong link isn't sent to the wrong person.

[mmbotelho]

The issues you mentioned above were all solved on the Dashboard mockups, right?

Once a proposal is accepted, the link is displayed on the UI - here's a refresher

[mmbotelho]

PR #655 should solve this issue

[sandrina-p]

@mmbotelho no it doesn't solve, but it's related only in the part of creating the layout for the invitation by link widget + modal.
The full functionality will be addressed in another PR.

---

Also, could you update the Figma file?

[mmbotelho]

Updated @sandrina-p 😄

[mmbotelho]

Just a heads up @sandrina-p

I reduced the copy of the "Share this link..." so it would fit in one line on desktop (as discussed on the hackathon)

[mmbotelho]

I believe your latest PR closes this issue, right @sandrina-p?

I am closing it because I'm 99% sure it does. Feel free to open it if not.