Gridstack.js: push Forks back to main gridstack repo

Created on 6 Mar 2020  ยท  11Comments  ยท  Source: gridstack/gridstack.js

Hello,
you are getting pinged because you have forked gridstack.js

You may not have noticed but the main branch is active, had many releases and hundreds of commits since you likely branched. I would like to ask for the community to contribute back any fixes/changes you may have done.

  1. use the latest build - it may have already fixed what you needed
  2. if you have local changes, please consider doing a PR with those changes for other to benefit
  3. if changes are too specific, consider patching the official lib instead of forking (see https://github.com/gridstack/gridstack.js#extend-library)

Noteworthy changes (and many many more)

  • v0.5.x lodash removal (450k), minimal jquery-ui.js (55k vs 248k)
  • v0.6.x huge responsive improvements with implementation of setColumn(N) and oneColumnMode options. Also much fewer unnecessary change callbacks
  • v1.x jquery was removed from the API and external dependencies (you can still use if you wish)

upcoming... converting to Typescript cleanup and looking at native HTML5 drag&drop. I could use some help!

sorry for the wide reach - wasn't sure best way to do this. If you have any questions please ping away... thank you!

-Alain

UPDATE: I added all 950 people then deleted them so hopefully you won't get bombarded with all replies unless you choose to track this issue. Hopefully the initial ping go out. Sorry if too many initial ones..

Most helpful comment

Sorry, I received your ping, but had no viable input to ping back. I guess I'm pinging for ping's sake, and so that you don't feel so lonely or unappreciated. Certainly not the case. Please keep up the great work!

All 11 comments

I'd suggest rewritting the engine to use the CSS grid, depending on the implementation, it may be faster than doing the grid in js.

@adumesny Thanks for all the effort.

very sad... over 950 people ping and less than a handful of feedback (ok I have 5 fingers on each hand). Geeeh.... ๐Ÿ‘Ž

very sad... over 950 people ping and less than a handful of feedback (ok I have 5 fingers or each hand). Geeeh.... ๐Ÿ‘Ž

I think most people came here, did one thing, PRed it so they can continue their main project, and then they left.

Sorry, I received your ping, but had no viable input to ping back. I guess I'm pinging for ping's sake, and so that you don't feel so lonely or unappreciated. Certainly not the case. Please keep up the great work!

I checked my branch from 2015 and it had no commits made at all. Looks like I figured how to get things working without any modifications/fixes after all. Deleted the fork.

Big thanks for all the work here, definitely appreciated! :)

very sad... over 950 people ping and less than a handful of feedback (ok I have 5 fingers on each hand). Geeeh.... -1

It's only been a few days...

Thanks for the effort, I'll check it out when I have the time

I only forked for backup reasons. The only thing i changed is adding some css for a 24 column layout.

I only forked for backup reasons. The only thing i changed is adding some css for a 24 column layout.

@Autoflow I noticed some other project building with the sass file to generate 32 columns layouts, so starting next release I will be including the source sass files again.

if anyone with build/packing expertise can help me with #1243 that would be great!
(in my angular app I also get issues importing 1.x)

well little contribution, and 2.0.0 (typescript version with no jquery in main code) is out. closing...

Was this page helpful?
0 / 5 - 0 ratings

Related issues

myzhibie picture myzhibie  ยท  5Comments

javayoung picture javayoung  ยท  3Comments

ascendantofrain picture ascendantofrain  ยท  6Comments

PrincessOfSecret picture PrincessOfSecret  ยท  6Comments

metalheadz picture metalheadz  ยท  3Comments