Great_expectations: [Community contributed Expectations] - run_diagnostics() not working as `get_test_validator_with_data` reference cannot be found

Created on 18 Mar 2021  路  5Comments  路  Source: great-expectations/great_expectations

Describe the bug
The run_diagnostics() command used to validate/test community contributed expectations fails after this PR removed the local function get_test_validator_with_data. I can see this function exists inside test_utils.py but it is not imported on self_check_util.py

To Reproduce
Steps to reproduce the behavior:

  1. Pick an existing community developed expectation (inside contrib/experimental/great_expectations_experimental/expectations) and run it.
  2. The call to self_check_report = ExpectColumnValuesToBeNormallyDistributed().run_diagnostics() fails with the following error
    {
      "error_message": "name 'get_test_validator_with_data' is not defined",
      "stack_trace": "Traceback (most recent call last):\n  File \"Documents/Personal/projects/great_expectations/great_expectations/expectations/expectation.py\", line 803, in run_diagnostics\n    execution_engines,\n  File \"Documents/Personal/projects/great_expectations/great_expectations/expectations/expectation.py\", line 907, in _get_test_results\n    expectation_execution_engines_dict=execution_engines,\n  File \"Documents/Personal/projects/great_expectations/great_expectations/expectations/self_check_util.py\", line 1626, in generate_expectation_tests\n    validator_with_data = get_test_validator_with_data(\nNameError: name 'get_test_validator_with_data' is not defined\n"
    }

Expected behavior
Output validating that the expectation works and all tests passed

Environment (please complete the following information):

  • Operating System: MacOS
  • Great Expectations Version: 0.13.14
bug core-team-priority

All 5 comments

@maikelpenz Thank you for reporting this - we are working on a fix that will go out in the next minor release within a few days.

@alexsherstinsky That's the bug we talked about.

@eugmandel Is this already working in our latest version merged into develop as of last night? If so, then we can release today (or Monday) to unblock the user (next week would be preferred). Thanks.

@alexsherstinsky let's do a minor version release early next week.

This is the PR that (among other things) contains the fix: https://github.com/great-expectations/great_expectations/pull/2567

Was this page helpful?
0 / 5 - 0 ratings