Greasemonkey: After updating 3.11 -> 3.12, whenever I close Firefox, 2 firefox.exe instances remain

[darkred]

Using GM 3.11 (with a lot of usescripts and stored settings) in FF 55.0.3 x64 in win10.
Multiprocess is enabled. I quote from about:support :

Multiprocess Windows    1/1 (Enabled by default)
Web Content Processes   1/1

Whenever I run Firefox I see 3 firefox.exe instances in Task Manager _(provided that I have opened a web page, not only Firefox internal pages, otherwise they are 2)_.

So, today, I updated GM 3.11 -> 3.12, restarted Firefox(pressed 'Restart now'), all seemed to work ok, and then closed Firefox:
I noticed in Task Manager that unfortunately, 2 firefox.exe processes remained
and after 1 min the Mozilla Crash Reporter was displayed (and those 2 processes were eventually terminated).
Here is the crash report
and here is the related bugzilla bug: 1377277 - Crash in shutdownhang | NtWaitForAlertByThreadId | RtlSleepConditionVariableSRW | SleepConditionVariableSRW | mozilla::detail::ConditionVariableImpl::wait | mozilla::CondVar::Wait | nsEventQueue::GetEvent | nsThread::nsChainedEventQueue::GetEvent | nsT...

After that, whenever I close Firefox, 2 firefox.exe processes remain, every single time,
and so either I have to kill them manually, or wait for the Crash Reporter and have them terminated automatically.

What I did was restore my Firefox profile from yesterday (having GM 3.11)
and disabled automatic updating for GM.

I understand that this probably is a Firefox bug and not caused by GM,
nevertheless I wanted to report this to you.
I've also posted a link to this issue to the bugzilla bug.

PS. I couldn't recreate it in a fresh profile.
But, in my normal profile, even after disabling all other installed extensions
(AdBlock Plus, EHE for ABP, NoScript, RES Suite, Stylish)
the issue remains (the 2 firefox.exe processes are not closed)

[frankhalligan]

Same issue here. Just to add, my "fix" was to do an install of 3.11 directly over 3.12, no need to restore an older profile

[ghost]

I have same issue. I installed Greasemonkey 4 from dev channel and it showed only couple of installed scripts. Maybe 3.12 version has problem with migrating scripts to new storage and that causes breakage? I have about 20 scripts installed with some disabled.

[ghost]

More people are affected: https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/reviews/

[fireattack]

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1402201

[jerone]

Confirmed!
Restarting FF doesn't work anymore; it idles with minimal memory forever.
With GM disabled, FF cleanly restarts again.

Edit: downgrading to 3.11 works.

_Windows 10 64-bit_
_FF 55.0.3 64-bit_
_GM 3.12+_

Changes between 3.11 & 3.12: https://github.com/greasemonkey/greasemonkey/compare/ac955f21e6d30f8afae2a9013784c1a8b2aa8ae8...9d27f9ff11a080d174fec03727efdc13d030c5f9

[ghost]

It would be nice to at least revert changes from 3.12 otherwise people are going to destroy this great addon in reviews.

[darkred]

@arantius, maybe you wanted to close #2579 as duplicate, and closed this by mistake, instead?
This report has much more details.

[arantius]

Yep!

[fireattack]

None seemed to mention it here, but it will only do so with certain scripts.

In all 30+ scripts I have, only this one causes this shut down hang problem.

Also, the (problematic) script doesn't even to be enabled; even if disabled it still causes problem.

[mooms06]

+1 to fireattack, I have a dozen script installed, and only one is causing the issue: Dealabs Compagon.
It seems it's a specific (uncommon?) function that's causing the issue.

[ghost]

In my case troublemaker script was https://greasyfork.org/en/scripts/6456-install-user-script
This was also my only script with// @run-at document-end which is also the case with two scripts posted above? Coincidence?

[fireattack]

I have other scripts that have // @run-at document-end but do not cause problem.

It could still be a necessary condition, though, just not a sufficient one.

[PHIL-IP]

I have try with all my script disable and the problem is the same for me under FF 55.0.3 and Windows 10 (64) multiprocess is disable for me.

[fireattack]

You need to remove problematic scripts, not just disable, to fix it

[fdellwing]

I do not have that problem with my scripts. So I can confirm, it is only a problem with some scripts.

[killerz298]

I reverted to 3.11 while I wait for a fix. Hopefully we don't have to wait for the new extension.

[arantius]

Both of the scripts linked above use a data: URL for their @icon. I've got a workaround prepared which causes the crash not to happen (I think..), but also want to make it really work, which it probably doesn't today.

[jerone]

@arantius commented on Sep 25, 2017, 5:59 PM GMT+2:

Both of the scripts linked above use a data: URL for their @icon.

I can confirm that I have at least one script that uses an data: URL for their @icon.

[arantius]

Above few commits should resolve this.

[jerone]

@arantius commented on Sep 25, 2017, 8:44 PM GMT+2:

Above few commits should resolve this.

I can confirm ✔️ that v3.14 allows restarts of FF again. 🎉