Grav-plugin-admin: Chrome : Unable to click on list-encapsulated markdown editor fields

[parcand]

List-encapsulated markdown editor fields are not responding to mouse clicks in Chrome.

[carlu93]

I can confirm this happening on Windows 10 with Chrome 59 dev. Right clicking in the text will move the cursor to the desired place. Left clicking and dragging is not working.

[teroyks]

I have the same issue (latest Grav, macOS Sierra, Chrome 57.0.

Works fine on latest Safari.

[lukepolak]

Same here.

You can get into editor by clicking on any toolbar buttons or by tabbing from previous field in list, so that's workaround for me for now. Also, sometimes contents of those editor fields are not shown when you enter to edit that page.

Any idea what could cause this?

[flaviocopes]

This is surely a regression, as I'm sure it worked before. Need to find out the commit that introduced the problem, on it.

[flaviocopes]

@w00fz I tracked this down to the sortablejs library bump in composer.json in https://github.com/getgrav/grav-plugin-admin/commit/49a9c43d4b42875f05c11c763a11154cf967f61f.

Setting it to "sortablejs": "1.4.2" (instead of ^1.5.1) and rebuilding the js, works fine again.

Could not find a changelog for that lib, will need to git-bisect (quite a few commits since 1.4.2) until I find what is the issue.
In the meantime @rhukster I pushed an updated vendor lib so if we want to release, it will fix the problem.

[w00fz]

Might be a setting that needs enabling.

[honzabilek4]

Hi,
this is still relevant even after the latest admin plugin update to version 1.6.0.

• Left click doesn't move the cursor, right click works.
• Tested in various browsers (Firefox, Safari, Edge..) however, it affects only Chrome (both Win/macOS versions)

Can we please reopen this issue?

[rhukster]

Grrr.. thought this was sorted

[w00fz]

What is the Chrome version you are using @honzabilek4 ? I did see this issue myself but after I upgraded Chrome it seems to be working fine again.
I'm running Version 61.0.3163.100 (Official Build) (64-bit).

Can you check your version? And if it's still an issue could you please paste a yaml sample for me to use? As of right now I can't reproduce this issue anymore.

[honzabilek4]

Hi,
I've got the exact same version of Chrome right now.
The very minimal yaml snippet having this issue would be:

title: Home
'@extends':
    type: default
    context: blueprints://pages
form:
  fields:
    tabs:
      fields:        
        customTab:
          type: tab
          title: Custom Tab
          @ordering: -3
          fields:
            header.persons:
              type: list
              title: Markdown list
              collapsed: false
              style: vertical
              btnLabel: Add Item
              fields:
                .description:
                  type: markdown
                  label: Text

In aa18112 @flaviocopes fixed the issue by reverting sortalbejs to version ^1.4.2, however in current version of admin plugin sortablejs is on ^1.6.0. Could this possibly fix it again?

[w00fz]

Well it certainly could but I’d rather try to resolve the issue while keeping the dependencies we use up to date.

I will take a look today, thanks for the snippet!

[w00fz]

Hey @honzabilek4,
I just tested with your yaml and still cannot reproduce. However I just realized I did update the dependencies very recently (https://github.com/getgrav/grav-plugin-admin/commit/814298c26244548717190f3d7e6d61034ddec9c0) and after 1.6.0. The update included codemirror so I'm thinking this issue is not reproducible for me because I'm running on persistent develop environment.

Would you mind trying out the develop version of admin to see if that is actually sorting out the issue for you?

Cheers

[honzabilek4]

Sure, I'll let you know asap.

[honzabilek4]

Okay, I can now confirm that after upgrading the dependencies in 814298c everything works just as fine.
Cool. Thanks for your help @w00fz.

[rhukster]

Great thanks.