Graphqlbundle: Missing dependencies

Created on 20 Jan 2020  路  6Comments  路  Source: overblog/GraphQLBundle

| Q | A
| ---------------- | -----
| Bug report? | yes

The ArgumentTransformer needs the symfony/property-access component.
We should update the composer.json accordingly or we get a Class Not found Exception.

bug
Source
picture Vincz
👍3

Most helpful comment

The symfony/validator is missing too.

picture Vincz on 21 Jan 2020
👍2

All 6 comments

The symfony/validator is missing too.

Vincz picture Vincz on 21 Jan 2020
👍2

This is normal, validator is optional

mcg-web picture mcg-web on 21 Jan 2020

Ok, so I made a PR to fix the ArgumentsTransformer.
View #642

Vincz picture Vincz on 21 Jan 2020

This is normal, validator is optional

https://getcomposer.org/doc/04-schema.md#suggest

wiese picture wiese on 3 Feb 2020

Yes @wiese this is an acceptable fix, do you want to submit a PR for 0.13 branch?

mcg-web picture mcg-web on 3 Feb 2020

@mcg-web I was about to but then realized it is already mentioned in require-dev... Keep in mind I do not know how this code base does what it does and what (if any) is its "plan B" if symfony/validator is not installed.

642 seems to push to truly make it optional but there is more to this.

wiese picture wiese on 5 Feb 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ruudk picture ruudk  路  5Comments
Vincz picture Vincz  路  3Comments
apoberez picture apoberez  路  3Comments
VincentClair picture VincentClair  路  4Comments
tjuenger picture tjuenger  路  3Comments