Graphql: Support extra @Args options (code first)

Created on 18 Mar 2019  路  4Comments  路  Source: nestjs/graphql

I'm submitting a...


[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior


Cannot create nullable resolver arguments.

Expected behavior


Resolver arguments should support the same/sub-set of options as in type-graphql:

  • nullable
  • defaultValue
  • description

Minimal reproduction of the problem with instructions


Again, sorry for my poor english, here is a small test case to demonstrate the expected behaviour: https://github.com/zhenwenc/nest-graphql-issues/blob/master/test/arguments-options.spec.ts

Environment



Nest version: 6.0.0
picture zhenwenc

Most helpful comment

@Args({
  name: 'id',
  type: () => String,
  nullable: false,
  defaultValue: '1',
})
picture kamilmysliwiec on 19 Mar 2019
👍13

All 4 comments

It should be fixed in 6.0.1 :) Let me know if you face any issue

kamilmysliwiec picture kamilmysliwiec on 18 Mar 2019
🎉1

How is this supposed to be used? Can you give an example code?

nsams picture nsams on 19 Mar 2019 
@Args({
  name: 'id',
  type: () => String,
  nullable: false,
  defaultValue: '1',
})
kamilmysliwiec picture kamilmysliwiec on 19 Mar 2019
👍13

Untitled
You need to change your documentation. It should be:
getAuthor(
@Args( { name: "firstName", nullable: true }) firstName?: string,
@Args( { name: "lastName", defaultValue: '' }) lastName?: string,
) {}

vinhtri97 picture vinhtri97 on 28 Apr 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

harm-less picture harm-less  路  4Comments
vnenkpet picture vnenkpet  路  5Comments
JayAhn2 picture JayAhn2  路  3Comments
moltar picture moltar  路  4Comments
willsoto picture willsoto  路  5Comments