Graphql: Remove query `temp__: Boolean` when schema is already described.

Created on 6 Feb 2019  路  7Comments  路  Source: nestjs/graphql

I'm submitting a...


[ ] Regression 
[x] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior


When we provide typePaths for loading gql schema, we get query temp__: Boolean with our queries always.
I don't know, is it a bug or feature request, that why I mark two.
Here I found that you add temp__ query at any way.

Expected behavior


Add temp query only when we haven't any of schema described.

Minimal reproduction of the problem with instructions


Simple project repo

What is the motivation / use case for changing the behavior?


It's add a misunderstanding when we use schema as a contract.

Environment


Nest version: 5.5.0

We use @nestjs/graphql#5.4.0, but I've checked it on a latest version.

For Tooling issues:
- Node version: v10.13.0  
- Platform:  Mac

Others:

Kudos

Thanks man, you make a great job! NestJS is awesome framework!

potential issue done

Most helpful comment

Hey, I have a question: how can i test my code locally?

All 7 comments

Fully understand. Would you like to create a PR :)?

Ok, I will :)

Hey, I have a question: how can i test my code locally?

Sorry for my late response - I was insanely busy recently :(

It should be fixed in the @next version ($ npm i @nestjs/graphql@next). You will also have to update @nestjs/core to 6.2.0 ($ npm i @nestjs/[email protected]). Please, let me know if you face any issue.

Awesome! No problem!

I've spent some time to fix that, and understand that too much code for such small fix and wanted to close the issue, but you fix that!
Thanks so much!

I'll check and give feedback!

Published as 6.2.0 ($ npm i @nestjs/graphql@latest). You will also have to update @nestjs/core to 6.2.0 ($ npm i @nestjs/core@latest)

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Was this page helpful?
0 / 5 - 0 ratings