Graphql-yoga: Add request to context for graphql subscriptions

Created on 12 Jul 2018  路  11Comments  路  Source: dotansimha/graphql-yoga

GraphQL queries and mutations are provided { request, response } to create a context based on the request. Unfortunately subscriptions are only provided { connection } despite webSocket being available in scope.

So either provide webSocket too or provide the request from webSocket.upgradeReq

statustale

Most helpful comment

This issue should be kept open, I don't understand why stale bot closes issues 'if no further activity occurs'. This is is still a feature that I think would be a worthy addition to graphql-yoga, but no maintainer has responded to this issue yet. Why should it be closed if it is still an issue?

All 11 comments

same here

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

This issue should be kept open, I don't understand why stale bot closes issues 'if no further activity occurs'. This is is still a feature that I think would be a worthy addition to graphql-yoga, but no maintainer has responded to this issue yet. Why should it be closed if it is still an issue?

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

Still open...

Any update on merging this?

Will probably not happen unless you know one of the core contributors. There have been multiple releases (even major) since my pull request. And the requested change is a single line, it's a adding a parameter and fully backwards compatible...

So it's simply no one with rights to merge is interested in it.

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

+1

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

Hey :wave:, It seems like this issue has been inactive for some time. In need for maintaining clear overview of the issues concerning the latest version of graphql-yoga we'll close it.
Feel free to reopen it at any time if you believe we should futher discuss its content. :slightly_smiling_face:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

marktani picture marktani  路  5Comments

joshhopkins picture joshhopkins  路  3Comments

asci picture asci  路  3Comments

woss picture woss  路  5Comments

AhmadEl-Banna picture AhmadEl-Banna  路  5Comments