Graphql-shield: Problems work with the renamed field

Created on 8 Jan 2019 · 10Comments · Source: maticzav/graphql-shield

When I add rules to a relation field such as messages, sometimes I may be want to get the messages NOT_READ or READ in one query. Just like this:

query {
  me {
    id
    messagesNotRead: messages(where: {status: NOT_READ}, orderBy: createdAt_DESC) {
        id
        status
    }
    messages(where: {status: READ}, orderBy: createdAt_DESC) {
        id
        status
    }
  }
}

But after use this middleware, add some rules(like isAuthenticated) to the messages field of type User, the result of the query above is not worked correctly. The renamed field messagesNotRead
cannot work through the validation of the messages field.
The value of messagesNotRead field is just the same of messages above:

{
  "data": {
    "me": {
      "id": "cjn105vxk00110759vg8eq8gz",
      "messagesNotRead": [
        {
          "id": "cjoy6mxbm011k0759uaito9hs",
          "status": "READ"
        },
        {
          "id": "cjoy3qcsj010807595jbtqt35",
          "status": "READ"
        },
      ],
      "messages": [
        {
          "id": "cjoy6mxbm011k0759uaito9hs",
          "status": "READ"
        },
        {
          "id": "cjoy3qcsj010807595jbtqt35",
          "status": "READ"
        },
        ]
    }
  }
}

when just rename the messages without an additional messages field，the renamed field just return null, not []:

query {
  me {
    id
    messagesNotRead: messages(where: {status: NOT_READ}, orderBy: createdAt_DESC) {
        id
        status
    }
  }
}

{
  "data": {
    "me": {
      "id": "cjn105vxk00110759vg8eq8gz",
      "messagesNotRead": null
    }
  }
}



md5-0867ce19311f444d02594b444a676736



query {
  me {
    id
    messages(where: {status: NOT_READ}, orderBy: createdAt_DESC) {
        id
        status
    }
  }
}



md5-442a2276f0e7cfb5911d8f20765f2def



{
  "data": {
    "me": {
      "id": "cjn105vxk00110759vg8eq8gz",
      "messages": []
    }
  }
}

kinquestion

Source

baby1990

All 10 comments

Hey @baby1990 👋,

That's an interesting question! Could you provide a reproduction repository or CodeSandbox? This way I can curb the issue a lot more quickly. 🙂

maticzav on 9 Jan 2019

Hey @baby1990 👋,

That's an interesting question! Could you provide a reproduction repository or CodeSandbox? This way I can curb the issue a lot more quickly. 🙂

I try to use graphql-yoga and graphql-shield to perform a simple demo for this situation. But the demo works correctly.

The problems above accurs when I use graphql-prisma / graphql-yoga / graphql-shield to perform a backend service. I wonder it maybe a problem of graphql-prisma.

baby1990 on 10 Jan 2019

@baby1990, let me know if you find any further information. Maybe this could be connected to field alias, could you try that as well?

Regardless, I think it would be super useful if we could have a common ground with a reproduction example. Let me know if you could compose that. 🙂

maticzav on 10 Jan 2019

@baby1990, let me know if you find any further information. Maybe this could be connected to field alias, could you try that as well?

Regardless, I think it would be super useful if we could have a common ground with a reproduction example. Let me know if you could compose that. 🙂

Ok, I work it out, https://github.com/baby1990/test-graphql-shield
The prisma version is 1.17, and the problems accurs...
Maybe it works well on newer version, I doesn't know about it.

baby1990 on 14 Jan 2019

@baby1990, let me know if you find any further information. Maybe this could be connected to field alias, could you try that as well?

Regardless, I think it would be super useful if we could have a common ground with a reproduction example. Let me know if you could compose that. 🙂

I try to update my prisma service to 1.24(latest version)，and the problems not resolved.

baby1990 on 16 Jan 2019

@baby1990, let me know if you find any further information. Maybe this could be connected to field alias, could you try that as well?

Regardless, I think it would be super useful if we could have a common ground with a reproduction example. Let me know if you could compose that. 🙂

I checked the response data of prisma-service, seems no problem. Maybe something went wrong with the resolve logic of graphql-yoga(work with prisma and shield)

baby1990 on 17 Jan 2019

@baby1990, let me know if you find any further information. Maybe this could be connected to field alias, could you try that as well?

Regardless, I think it would be super useful if we could have a common ground with a reproduction example. Let me know if you could compose that. 🙂

Actually, I tried to use the custom directives to do the permission instead of graphql-shield. But the problems not resolved. So I don't think there is something wrong with graphql-shield.

baby1990 on 21 Jan 2019

👍1

https://github.com/prisma/prisma/issues/3881#issuecomment-456842794

@maticzav this is totally unrelated to graphql-shield I think you can close this here 🙂