Graphql-ruby: Runtime Error Duplicate Type

Created on 15 May 2018  路  69Comments  路  Source: rmosolgo/graphql-ruby

I am seeing increasing number of runtime error Duplicate types.

I thought this mainly happened due to old api but I am using new class based API.

Has anyone else has faced this problem? It goes away after restating my dyno on heroku.

picture fameoflight
👍22

Most helpful comment

Hey, I think this issue can be fixed on 1.10, if:

  • The schema is all migrated to class-based definitions

  • New modules are used: 

    class MySchema < GraphQL::Schema 
use GraphQL::Execution::Interpreter 
use GraphQL::Analysis::AST 
end

In that setup, GraphQL-Ruby's approach to identifying the types in a schema is brand new, and much simpler. The specific case in #2448 is fixed, for example.

As a matter of housekeeping, I'm going to close this issue. If you try the approach I described above and still encounter this issue, please open a new issue with the full backtrace and a description of how you encountered the problem.

If you try to migrate and run into trouble, please open an issue for that! Thanks so much for your patience and help in debugging this. I think there's light at the end of the tunnel! 馃

picture rmosolgo on 12 Feb 2020
👍6 ❤2 🚀1 🎉1

All 69 comments

weird! could you tell me more about the error you're seeing? For example, does it happen while your app is starting up, or does it happen after it's running for a while? Can you share a stack trace? (I see this error during app boot sometimes)

rmosolgo picture rmosolgo on 15 May 2018

This happened few times during app boot on Heroku.

Not sure if this was related, but I was using ruby 2.5.1 but for now I have switched back to 2.4.2 to see if it's the cause. Hasn't been a problem in last 24 hours but will keep you updated.

here is the stack trace it happens when executing query 

May 14 21:50:23 goodly app[web] info app/controllers/api/graphql_controller.rb:16:in `create'
May 14 21:50:23 goodly app[web] info   
May 14 21:50:23 goodly app[web] info RuntimeError (Duplicate type definition found for name 'Company' (CompanyType, CompanyType})):
fameoflight picture fameoflight on 17 May 2018

@rmosolgo This seems to be happening more often with the upgrade. Any ideas on what might be causing this? Any fix or workarounds?

fameoflight picture fameoflight on 26 May 2018

No, I don't have any ideas. The three lines you shared above, is that the whole stack trace?

rmosolgo picture rmosolgo on 26 May 2018

Yep that's what I see on Heroku

fameoflight picture fameoflight on 26 May 2018

I haven't seen this problem in my tests. So unable to get a proper repro.

fameoflight picture fameoflight on 26 May 2018

I also have started to see this issue - it appears to happen (for me at least) if you attempt to perform two introspection queries, one after another.

Stack Trace

api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] RuntimeError (Duplicate type definition found for name 'DateTime' (, })):
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32]
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:161:in `visit'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:198:in `visit_field_on_type'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:178:in `block in visit_fields'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:177:in `each'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:177:in `visit_fields'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:136:in `visit'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:198:in `visit_field_on_type'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:178:in `block in visit_fields'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:177:in `each'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:177:in `visit_fields'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:136:in `visit'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:198:in `visit_field_on_type'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:178:in `block in visit_fields'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:177:in `each'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:177:in `visit_fields'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:136:in `visit'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:117:in `block in visit'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:117:in `each'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:117:in `visit'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/traversal.rb:36:in `initialize'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema.rb:955:in `new'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema.rb:955:in `rebuild_artifacts'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema.rb:271:in `types'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/validation.rb:134:in `block in <module:Rules>'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/validation.rb:19:in `block in validate'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/validation.rb:19:in `each'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/validation.rb:19:in `reduce'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema/validation.rb:19:in `validate'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/schema.rb:232:in `define'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] graphql (1.8.0) lib/graphql/define/instance_definable.rb:226:in `define'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] app/graphql/api_schema.rb:3:in `<main>'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] bootsnap (1.3.0) lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:100:in `load'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] bootsnap (1.3.0) lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:100:in `load'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:468:in `block in load_file'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:653:in `new_constants_in'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:467:in `load_file'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:365:in `block in require_or_load'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:37:in `block in load_interlock'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies/interlock.rb:14:in `block in loading'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies/interlock.rb:13:in `loading'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:37:in `load_interlock'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:348:in `require_or_load'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:502:in `load_missing_constant'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] bootsnap (1.3.0) lib/bootsnap/load_path_cache/core_ext/active_support.rb:43:in `load_missing_constant'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:193:in `const_missing'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:534:in `load_missing_constant'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] bootsnap (1.3.0) lib/bootsnap/load_path_cache/core_ext/active_support.rb:43:in `load_missing_constant'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:193:in `const_missing'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] app/controllers/api_controller.rb:33:in `graphql'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/abstract_controller/base.rb:194:in `process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_controller/metal/rendering.rb:30:in `process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/abstract_controller/callbacks.rb:42:in `block in process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/callbacks.rb:132:in `run_callbacks'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/abstract_controller/callbacks.rb:41:in `process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_controller/metal/rescue.rb:22:in `process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/notifications.rb:168:in `block in instrument'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/notifications/instrumenter.rb:23:in `instrument'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/notifications.rb:168:in `instrument'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_controller/metal/instrumentation.rb:32:in `process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_controller/metal/params_wrapper.rb:256:in `process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activerecord (5.2.0) lib/active_record/railties/controller_runtime.rb:24:in `process_action'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/abstract_controller/base.rb:134:in `process'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_controller/metal.rb:191:in `dispatch'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_controller/metal.rb:252:in `dispatch'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/routing/route_set.rb:52:in `dispatch'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/routing/route_set.rb:34:in `serve'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/journey/router.rb:52:in `block in serve'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/journey/router.rb:35:in `each'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/journey/router.rb:35:in `serve'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/routing/route_set.rb:840:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] makara (0.4.0) lib/makara/middleware.rb:16:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] app/middleware/catch_json_parse_errors.rb:12:in `_call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] app/middleware/catch_json_parse_errors.rb:7:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] rack (2.0.5) lib/rack/deflater.rb:34:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] rack (2.0.5) lib/rack/lint.rb:49:in `_call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] rack (2.0.5) lib/rack/lint.rb:37:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] rack (2.0.5) lib/rack/etag.rb:25:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activerecord (5.2.0) lib/active_record/migration.rb:559:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/callbacks.rb:98:in `run_callbacks'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/middleware/callbacks.rb:26:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/middleware/executor.rb:14:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/middleware/debug_exceptions.rb:61:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] railties (5.2.0) lib/rails/rack/logger.rb:38:in `call_app'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] railties (5.2.0) lib/rails/rack/logger.rb:26:in `block in call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/tagged_logging.rb:71:in `block in tagged'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/tagged_logging.rb:28:in `tagged'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/tagged_logging.rb:71:in `tagged'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] railties (5.2.0) lib/rails/rack/logger.rb:26:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] request_store (1.4.1) lib/request_store/middleware.rb:19:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/middleware/request_id.rb:27:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] rack (2.0.5) lib/rack/runtime.rb:22:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] actionpack (5.2.0) lib/action_dispatch/middleware/executor.rb:14:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] honeybadger (3.3.0) lib/honeybadger/rack/error_notifier.rb:33:in `block in call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] honeybadger (3.3.0) lib/honeybadger/agent.rb:337:in `with_rack_env'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] honeybadger (3.3.0) lib/honeybadger/rack/error_notifier.rb:30:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] honeybadger (3.3.0) lib/honeybadger/rack/user_feedback.rb:31:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] honeybadger (3.3.0) lib/honeybadger/rack/user_informer.rb:21:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] rack-cors (1.0.2) lib/rack/cors.rb:97:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] railties (5.2.0) lib/rails/engine.rb:524:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] puma (3.11.4) lib/puma/configuration.rb:225:in `call'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] puma (3.11.4) lib/puma/server.rb:632:in `handle_request'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] puma (3.11.4) lib/puma/server.rb:446:in `process_client'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] puma (3.11.4) lib/puma/server.rb:306:in `block in run'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] puma (3.11.4) lib/puma/thread_pool.rb:120:in `block in spawn_thread'
nater540 picture nater540 on 31 May 2018

Interesting! Thanks for reporting with a full stack trace, that's really helpful. Now let me think about it for a minute...

rmosolgo picture rmosolgo on 31 May 2018

One thing that stands out to me is this line: 

api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] app/graphql/api_schema.rb:3:in `<main>'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] bootsnap (1.3.0) lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:100:in `load'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] bootsnap (1.3.0) lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:100:in `load'
api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] activesupport (5.2.0) lib/active_support/dependencies.rb:468:in `block in load_file'

Those are lines related in _loading missing constants_, that is, ApiSchema didn't exist yet, so Rails went and loaded those files.

Does this usually happen at app boot, or does it happen at random times, while the app is running?

rmosolgo picture rmosolgo on 31 May 2018

Might be related: I got this error this when I added an enum named TargetType to a schema that already had an object named Target:

class Graph::Enums::TargetType < GraphQL::Schema::Enum
  # ...
end

class Graph::Objects::Target < GraphQL::Schema::Object
  # ...
end

The fix was to add graphql_name 'TargetType' to the enum, presumably because 1.8 was stripping 'Type' from the generated type name.

jcbpl picture jcbpl on 31 May 2018
👍6

Also, taking a look at this line: 

api_1    | [4fd823c6-855e-4302-b545-c74c46017b32] puma (3.11.4) lib/puma/thread_pool.rb:120:in `block in spawn_thread'

Are you using puma with many threads?

rmosolgo picture rmosolgo on 31 May 2018

(I wonder if the application boots, without loading ApiSchema, and then two threads both start loading those constants, but encounter a race condition, both trying to load the same types. But I'm not sure about that, because I think active_support/dependencies has mutexes to prevent that ...)

rmosolgo picture rmosolgo on 31 May 2018

@rmosolgo

Does this usually happen at app boot, or does it happen at random times, while the app is running?

Random times. I can generally perform one or two queries before this happens, although running the introspection query will instantly generate the error.

Initial startup log

api_1    | Puma starting in single mode...
api_1    | * Version 3.11.4 (ruby 2.4.4-p296), codename: Love Song
api_1    | * Min threads: 5, max threads: 5
api_1    | * Environment: development
api_1    | ** [Honeybadger] Initializing Honeybadger Error Tracker for Ruby. Ship it! version=3.3.0 framework=rails level=1 pid=7
api_1    | ** [Honeybadger] Development mode is enabled. Data will not be reported until you deploy your app. level=2 pid=7
api_1    | * Listening on tcp://0.0.0.0:3000
api_1    | Use Ctrl-C to stop

_(also answers your threading question)_

Here is the entire API schema file

GraphQL::Relay::ConnectionType.default_nodes_field = true

class ApiSchema < GraphQL::Schema
  query(Types::QueryType)
  mutation(Types::MutationType)

  max_depth(8)
  max_complexity(220)
  authorization(:pundit)

  instrument(:field, AssociationPreloadInstrumentation.new)

  use(GraphQL::Batch)

  rescue_from(ActiveRecord::RecordInvalid) do |error|
    'Some data could not be saved'
  end

  rescue_from(ActiveRecord::StatementInvalid) do |error|
    Honeybadger.notify(error)
    'An error has occurred and support has been notified. Thank you for your continued patience.'
  end

  rescue_from(ActiveRecord::RecordNotFound) do |error|
    'Could not find the record'
  end

  rescue_from(ActiveRecord::RecordNotUnique) do |error|
    'Some data could not be saved'
  end

  rescue_from(ActiveRecord::Rollback) do |error|
    'Some data could not be saved'
  end

  def self.id_from_object(object, type, ctx)
    GraphQL::Schema::UniqueWithinType.encode(
      type_definition.name,
      object.id,
      separator: '---'
    )
  end

  def self.object_from_id(node_id, ctx)
    type_name, object_id = GraphQL::Schema::UniqueWithinType.decode(
      node_id,
      separator: '---'
    )
    RecordLoader.for(type_name).load(object_id)
  end

  def self.resolve_type(type, obj, ctx)
    type_name = obj.class.name.split('::').last
    ApiSchema.types[type_name]
  end
end

# The following line will enable graphql-ruby to provide real values for reverse-direction has*Page checks.
# This will become the default behavior in a future graphql-ruby version.
# (But it is not the default behavior now because it has performance implications.)
# @see https://github.com/rmosolgo/graphql-ruby/pull/960
#
GraphQL::Relay::ConnectionType.bidirectional_pagination = true

GraphQL::Relay::BaseConnection.register_connection_implementation(
  ActiveRecord::Relation, GraphQL::Relay::RelationConnection
)

Side note, I just updated this to the class based style a few minutes ago and the error still occurs.

@jcbpl

The fix was to add graphql_name 'TargetType' to the enum, presumably because 1.8 was stripping 'Type' from the generated type name.

As of now I've only upgraded the schema to a class, but I wonder if this is still happening. Thanks for the advice, I'll go poke around and see what I can discover.

nater540 picture nater540 on 31 May 2018

@jcbpl

Tried using graphql_name as you suggested, unfortunately GraphQL still fails; however at least the error message makes _slightly_ more sense!

RuntimeError (Duplicate type definition found for name 'DateTimeType' (Types::DateTime, Types::DateTime}))

For reference, this is the DateTimeType in its entire glory

class Types::DateTime < Types::BaseScalar
  graphql_name 'DateTimeType'
  description 'An ISO-8601 encoded UTC date string.'

  def self.coerce_input(input_value, context)
    Time.iso8601(input_value).gmtime
  end

  def self.coerce_result(ruby_value, context)
    ruby_value.utc.iso8601
  end
end

I have a sneaking suspicion that @rmosolgo is on the right track with this issue (at least in my case) being a race condition - I just wish debugging Ruby inside a Docker container wasn't the equivalent of pulling your own teeth without anesthetic :grimacing:

nater540 picture nater540 on 31 May 2018
👍2

I see in the startup log:

Development mode is enabled.

Is this in development, or after deploying?

(I think @fameoflight 's issue was in production, on heroku)

rmosolgo picture rmosolgo on 31 May 2018

@rmosolgo

Is this in development, or after deploying?

Development; I have not pushed these changes to k8s - want to get rid of this error before I test 1.8 on production.

nater540 picture nater540 on 31 May 2018

I also see this in development.

And yes I am using puma with multiple threads on prod and development.

fameoflight picture fameoflight on 2 Jun 2018

Deployed the 1.8 branch that has been crashing in development to a beta endpoint and it appears fine -- same docker image, puma config, etc.

NAME                   READY     STATUS    RESTARTS   AGE
api-684466ddf8-f4bw9   1/1       Running   0          2d
api-684466ddf8-hfsd8   1/1       Running   0          2d
api-684466ddf8-lxpcj   1/1       Running   0          2d

@fameoflight - do you have a development stack trace?

@rmosolgo - any chance you've had an epiphany on what might be the cause?

nater540 picture nater540 on 4 Jun 2018

Seeing this as well.

buffpojken picture buffpojken on 16 Jun 2018

@rmosolgo I can share my sentry stack trace in private let me know if it would be helpful

fameoflight picture fameoflight on 17 Jun 2018 
RuntimeError: Duplicate type definition found for name 'User' (User::GraphqlType, User::GraphqlType})
  from graphql/schema/traversal.rb:161:in `visit'
  from graphql/schema/traversal.rb:198:in `visit_field_on_type'
  from graphql/schema/traversal.rb:178:in `block in visit_fields'
  from graphql/schema/traversal.rb:177:in `each'
  from graphql/schema/traversal.rb:177:in `visit_fields'
  from graphql/schema/traversal.rb:136:in `visit'
  from graphql/schema/traversal.rb:198:in `visit_field_on_type'
  from graphql/schema/traversal.rb:178:in `block in visit_fields'
  from graphql/schema/traversal.rb:177:in `each'
  from graphql/schema/traversal.rb:177:in `visit_fields'
  from graphql/schema/traversal.rb:136:in `visit'
  from graphql/schema/traversal.rb:198:in `visit_field_on_type'
  from graphql/schema/traversal.rb:178:in `block in visit_fields'
  from graphql/schema/traversal.rb:177:in `each'
  from graphql/schema/traversal.rb:177:in `visit_fields'
  from graphql/schema/traversal.rb:136:in `visit'
  from graphql/schema/traversal.rb:198:in `visit_field_on_type'
  from graphql/schema/traversal.rb:178:in `block in visit_fields'
  from graphql/schema/traversal.rb:177:in `each'
  from graphql/schema/traversal.rb:177:in `visit_fields'
  from graphql/schema/traversal.rb:136:in `visit'
  from graphql/schema/traversal.rb:198:in `visit_field_on_type'
  from graphql/schema/traversal.rb:178:in `block in visit_fields'
  from graphql/schema/traversal.rb:177:in `each'
  from graphql/schema/traversal.rb:177:in `visit_fields'
  from graphql/schema/traversal.rb:136:in `visit'
  from graphql/schema/traversal.rb:117:in `block in visit'
  from graphql/schema/traversal.rb:117:in `each'
  from graphql/schema/traversal.rb:117:in `visit'
  from graphql/schema/traversal.rb:36:in `initialize'
  from graphql/schema.rb:955:in `new'
  from graphql/schema.rb:955:in `rebuild_artifacts'
  from graphql/schema.rb:270:in `types'
  from graphql/schema/possible_types.rb:16:in `initialize'
  from graphql/schema.rb:180:in `new'
  from graphql/schema.rb:180:in `initialize_copy'
  from graphql/define/instance_definable.rb:129:in `initialize_dup'
  from graphql/define/instance_definable.rb:129:in `dup'
  from graphql/define/instance_definable.rb:129:in `redefine'
  from graphql/schema.rb:719:in `to_graphql'
  from graphql/schema/member/accepts_definition.rb:120:in `to_graphql'
  from graphql/schema.rb:668:in `graphql_definition'
  from forwardable.rb:223:in `execute'
  from app/controllers/api/internal/graphql_controller.rb:16:in `create'
  from action_controller/metal/basic_implicit_render.rb:6:in `send_action'
  from abstract_controller/base.rb:194:in `process_action'
  from action_controller/metal/rendering.rb:30:in `process_action'
  from abstract_controller/callbacks.rb:42:in `block in process_action'
  from active_support/callbacks.rb:109:in `block in run_callbacks'
  from raven/integrations/rails/controller_transaction.rb:7:in `block in included'
  from active_support/callbacks.rb:118:in `instance_exec'
  from active_support/callbacks.rb:118:in `block in run_callbacks'
  from active_support/callbacks.rb:136:in `run_callbacks'
  from abstract_controller/callbacks.rb:41:in `process_action'
  from action_controller/metal/rescue.rb:22:in `process_action'
  from action_controller/metal/instrumentation.rb:34:in `block in process_action'
  from active_support/notifications.rb:168:in `block in instrument'
  from active_support/notifications/instrumenter.rb:23:in `instrument'
  from active_support/notifications.rb:168:in `instrument'
  from action_controller/metal/instrumentation.rb:32:in `process_action'
  from action_controller/metal/params_wrapper.rb:256:in `process_action'
  from active_record/railties/controller_runtime.rb:24:in `process_action'
  from abstract_controller/base.rb:134:in `process'
  from action_view/rendering.rb:32:in `process'
  from action_controller/metal.rb:191:in `dispatch'
  from action_controller/metal.rb:252:in `dispatch'
  from action_dispatch/routing/route_set.rb:52:in `dispatch'
  from action_dispatch/routing/route_set.rb:34:in `serve'
  from action_dispatch/journey/router.rb:52:in `block in serve'
  from action_dispatch/journey/router.rb:35:in `each'
  from action_dispatch/journey/router.rb:35:in `serve'
  from action_dispatch/routing/route_set.rb:840:in `call'
  from omniauth/strategy.rb:190:in `call!'
  from omniauth/strategy.rb:168:in `call'
  from omniauth/builder.rb:63:in `call'
  from rack/throttle/limiter.rb:35:in `call'
  from rack/deflater.rb:34:in `call'
  from warden/manager.rb:36:in `block in call'
  from warden/manager.rb:35:in `catch'
  from warden/manager.rb:35:in `call'
  from rack/tempfile_reaper.rb:15:in `call'
  from rack/etag.rb:25:in `call'
  from rack/conditional_get.rb:38:in `call'
  from rack/head.rb:12:in `call'
  from action_dispatch/http/content_security_policy.rb:18:in `call'
  from rack/session/abstract/id.rb:232:in `context'
  from rack/session/abstract/id.rb:226:in `call'
  from action_dispatch/middleware/cookies.rb:670:in `call'
  from action_dispatch/middleware/callbacks.rb:28:in `block in call'
  from active_support/callbacks.rb:98:in `run_callbacks'
  from action_dispatch/middleware/callbacks.rb:26:in `call'
  from action_dispatch/middleware/debug_exceptions.rb:61:in `call'
  from action_dispatch/middleware/show_exceptions.rb:33:in `call'
  from lograge/rails_ext/rack/logger.rb:15:in `call_app'
  from rails/rack/logger.rb:28:in `call'
  from action_dispatch/middleware/remote_ip.rb:81:in `call'
  from request_store/middleware.rb:19:in `call'
  from rack/timeout/core.rb:123:in `block in call'
  from rack/timeout/support/timeout.rb:19:in `timeout'
  from rack/timeout/core.rb:122:in `call'
  from action_dispatch/middleware/request_id.rb:27:in `call'
  from rack/method_override.rb:22:in `call'
  from rack/runtime.rb:22:in `call'
  from rack/timeout/core.rb:123:in `block in call'
  from rack/timeout/support/timeout.rb:19:in `timeout'
  from rack/timeout/core.rb:122:in `call'
  from active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
  from action_dispatch/middleware/executor.rb:14:in `call'
  from action_dispatch/middleware/static.rb:127:in `call'
  from rack/sendfile.rb:111:in `call'
  from rack/cors.rb:97:in `call'
  from raven/integrations/rack.rb:51:in `call'
  from rails/engine.rb:524:in `call'
  from puma/configuration.rb:225:in `call'
  from puma/server.rb:632:in `handle_request'
  from puma/server.rb:446:in `process_client'
  from puma/server.rb:306:in `block in run'
  from puma/thread_pool.rb:120:in `block in spawn_thread'
fameoflight picture fameoflight on 17 Jun 2018

If anyone wants to debug this in development, here's one approach you can take. Add this initializer:

https://gist.github.com/rmosolgo/4eba313cb21189d952152ce3f1a6135a

Then restart rails, replicate the error, and share the log. Maybe it will give some clue to how constants are being loaded.

rmosolgo picture rmosolgo on 20 Jun 2018

By the way, I was working this out with @nater540 over email and got to the root of the problem.

In this particular case, there was an initializer which made a reference to one of the GraphQL types. Later, after the GraphQL type was reloaded, there was a conflict, because on one side, the _stale_ type (from the initializer) was being used in the schema, but elsewhere, the newly-reloaded type was being used. Since those classes are different Ruby objects, they can't be used for the same GraphQL type.

The solution was to move the initializer code into my_schema.rb, so that it would be re-evalutated whenever the schema was reloaded.

If you want to do similar debugging, see my previous comment: https://github.com/rmosolgo/graphql-ruby/issues/1505#issuecomment-398783287

rmosolgo picture rmosolgo on 20 Jun 2018
👍1

@rmosolgo
I also encountered this same issue.
I have been battling this for quite a while and I am out of ideas.
I created a class called mutation and another called query and I give those to the schema. Since I will have multiple models in my backend, I decided to structure my mutations the same way so I broke them into files.

Now I have something like this.
https://gist.github.com/adventCloud/1b7171c484f4ccb23188971febfacfca

This happens randomly and only restarting the server seems to fix it, sometimes.
Sometimes it says there are duplicate PostInput definitions, other times its UserInput, Other times Its QueryType, and sometimes its a fix of a few.

I get the same traceback. It hits traversal.rb

What would you suggest I do to debug this issue further? I tried your initializer you advised to use, but it only runs on server start, or rails console. but when it breaks, nothing gets logged.
I also checked all my initializer files, and there is no references to Graphql types.

adventCloud picture adventCloud on 6 Jul 2018
👍1

Did you try the debug suggestion in https://github.com/rmosolgo/graphql-ruby/issues/1505#issuecomment-398783287 ?

rmosolgo picture rmosolgo on 6 Jul 2018

I did but I only get output on server restart or on rails console and I don鈥檛 see any graphql constants

adventCloud picture adventCloud on 6 Jul 2018

I recently refactored my project to the 1.8 Class Syntax and have been running into the same issue in production as well. It semi-randomly occurs to pretty much any GraphQL type, with errors like these:

RuntimeError: Duplicate type definition found for name 'Restaurant' at 'Field User.adminRestaurants's return type' (GraphType::RestaurantType, GraphType::RestaurantType)

RuntimeError: Duplicate type definition found for name 'Photo' at 'Field MenuItem.photos's return type' (GraphType::PhotoType, GraphType::PhotoType)

... seemingly all other types

Some attempted solutions so far:

  1. Add /app/graphql directory to eager_load_paths in application.rb

Seemingly no effect.

  1. Refactor all GraphQL Types referenced in field definitions from classes to strings that are constantized later on

Alongside this solution I tried patching the BuildType#parse_type method with alternate Object.get_const vs .constantize method calls for handling the string types- neither seemed to have an effect.

  1. Refactor all Types under an alternate namespace (e.g., GraphType:: rather than Types::)

Seemingly no effect (same errors with a different module name).

  1. Remove Traversal#visit prev_type equality check

I just deployed this hack to get the random errors to stop. I'm expecting there to be some side-effect, such as a memory leak or something.

Any other suggestions would be appreciated.

justisb picture justisb on 24 Jul 2018

Over the last six hours and ~90k user sessions since disabling the duplicate type error I have not really seen any adverse effects. I'll dive deeper into the cause of the error next weekend, if nobody else has any additional insights by then.

justisb picture justisb on 25 Jul 2018

@justisb any way you can share a small repo or gist of your changes?

@rmosolgo wondering if you have any opinions for fixes posted by @justisb

fameoflight picture fameoflight on 26 Jul 2018

Here's the fork of graphql-ruby I'm running currently, I don't really think this is a fix so much as it's masking the symptoms though: https://github.com/rmosolgo/graphql-ruby/compare/master...justisb:parse-type-three

justisb picture justisb on 26 Jul 2018

Disabling that error might work, but it means that the same graphql type is represented by more than one Ruby object, so it could result in some pretty weird behaviors if those Ruby objects are different at all.

Again, if anyone wants to debug in development, my recommendation is here: https://github.com/rmosolgo/graphql-ruby/issues/1505#issuecomment-398783287

rmosolgo picture rmosolgo on 26 Jul 2018

I haven't been able to reproduce the issue in development, it only occurs in production (Rails on Puma on Heroku).

justisb picture justisb on 26 Jul 2018

馃槚

rmosolgo picture rmosolgo on 26 Jul 2018

Joining the Party, we went from 1.7.X > 1.8.5 and ever since have occasional batches of exceptions

bessey picture bessey on 26 Jul 2018
👍2

Also Heroku?

rmosolgo picture rmosolgo on 26 Jul 2018

Perhaps a compromise for now could be changing prev_type.equal? from a strict equality to only checking if the type names are the same. And/or logging a "proceed at your own risk" warning rather than throwing an exception.

FWIW since disabling the error I haven't seen any unusual exceptions and the memory curves for each of my instances has been normal. Though I agree it's still indicative that something strange is going on, particularly since it's so infrequent/random. Perhaps some threading related issue.

justisb picture justisb on 26 Jul 2018

@rmosolgo no, AWS EC2 + Nginx + Passenger Enterprise.

Things worth noting:
I have only converted one type to the 1.8 syntax, and that type just so happens to be the only type causing issues. (Edit, actually I've also upgraded the schema itself to be 1.8)

Example failure https://gist.github.com/bessey/9ea70d8a9127c28adf680524c4ec28ef

It also happens on a single machine in a fleet of I think 4-8, and a restart alleviates the problem (till it comes back).

The passenger instances are configured for multithreaded, so definitely room for race condition induced bugs there.

All signs point to something around constant loading.

bessey picture bessey on 26 Jul 2018

one type to the 1.8 syntax, and ... I've also upgraded the schema itself to be 1.8

Interesting!

Thanks for sharing that backtrace. Here's one clue that stood out to me: 

  from graphql/schema.rb:729:in `to_graphql'
  from graphql/schema/member/accepts_definition.rb:120:in `to_graphql'
  from graphql/schema.rb:677:in `graphql_definition'
from /home/usr.local/ruby251/lib/ruby/2.5.0/forwardable.rb:223:in `multiplex'

Schema.graphql_definition was called, and instead of finding a cached @graphql_definition, it's re-converting everything using the .to_graphql method. 馃 It could be that two threads are doing that work at the same time an-- wait, but wouldn't they find the _same_ classes ...

Well, one thing you could try is to eagerly cause the schema to run that transformation, for example at the end of your schema file, call .graphql_definition on it: 

class MySchema < GraphQL::Schema 
  # ... 
end 

# This processes the schema members and makes some caches on the schema, 
# maybe it's subject to a race condition? 
# So eagerly warm that cache at load time: 
MySchema.graphql_definition

That way, by the time that the server starts handling requests, that work will be done already. Want to give it a spin?

rmosolgo picture rmosolgo on 26 Jul 2018
👍5 👀2 🎉1

Tests pass giving it a try on prod now at www.goodlyapp.com

fameoflight picture fameoflight on 27 Jul 2018

We're trialing this in production now. I'll keep you posted, though we've been running 1.8 for about a week now and the bug has only manifested twice, so expect radio silence for a bit wether or not its fixed.

In the meantime since this hasn't thus far affected more than one server at a time, I'm thinking of adding GraphQL::Schema::Printer.print_schema(schema) to our PingController, so that bad servers get taken out of the pool automatically by our load balancer's health check mechanism.

bessey picture bessey on 27 Jul 2018

We've had no problems since adding the MySchema.graphql_definition code, so I think its safe to say that dramatically shrunk if not stopped the edge case occurring.

A question for others experiencing the bug: is anyone still having troubles who is _all in_ on the 1.8 syntax? I'm assuming the edge case involves a mix of 1.8 + pre-1.8 syntax in a single schema, though I have no proof.

bessey picture bessey on 1 Aug 2018
👍1

@bessey I did a hard cut from the old syntax fully to the 1.8 syntax, so no mixed usage, and started experiencing the error.

I haven't tried the pre-warming .graphql_definition fix yet.

justisb picture justisb on 1 Aug 2018

Just started experiencing this issue again; unfortunately it is starting to occur on production and not just development like before (at least for me)
Backtrace available here => https://pastebin.com/2x8FS4vR

Update
Just deployed the graphql_definition suggestion that @rmosolgo made above, so fingers crossed that fixes the issue.

nater540 picture nater540 on 2 Aug 2018

@rmosolgo I have been using graphql_definition haven't experienced a single problem for one week. So I think I will be good for now.

I am not sure if I had to remove bootsnap as well. So if you are still having problem try removing bootsnap.

fameoflight picture fameoflight on 4 Aug 2018

For what it's worth, this issue appeared for me when I switched from ruby 2.3.1 to 2.5.1.
This confirms @fameoflight experience.

such picture such on 10 Aug 2018

@such you will still see them in Ruby 2.3.1 was less frequently. You should try the workaround hasn't been a problem for us at Goodly (www.goodlyapp.com) for past 2 weeks.

fameoflight picture fameoflight on 10 Aug 2018

Another similar update- after implementing the Schema.graphql_definition traversal warmup trick, we're also no longer experiencing any mismatched/duplicate type errors.

justisb picture justisb on 11 Aug 2018

We've also experienced this issue at the company I work for. It's a pretty severe bug -- it put one of our production containers into a state where all GraphQL requests experienced an exception.

We're implementing the Schema.graphql_definition workaround, and will report back if that doesn't work.

I took a bit of a look through the code. It seems pretty clear that the code which Schema.graphql_definition is not thread-safe in lots of ways. For example, the @rebuilding_artifacts boolean here is obviously not thread-safe and could cause an exception if two thread call into that method at the same time (one thread sets the boolean to true, then when the other thread calls the method, the exception is raised):

https://github.com/rmosolgo/graphql-ruby/blob/368e68a3979c8a7453f6a7466ff80d401fbede68/lib/graphql/schema.rb#L1031-L1048

However, the actual error discussed here is in traversal.rb. It happens when the previously-defined type name doesn't match the type definition we're currently visiting. I didn't manage to figure out exactly why this happens, but some things I noticed were:

  • Traversal's @type_map hash is exposed to code outside of the class via an attr_reader. This code could potentially mutate the hash, triggering this issue.
  • Schema's rebuild_artifacts method stores a reference to this hash (not a copy of it) in @types, which is then exposed via a types method.
  • In my project, if I do MySchema.types["MyType"] == MyTypeDefinition I get a false. It looks like something is hooking in and redefining the type for one reason or other. I didn't manage to track this down, but I suspect this is the root cause of the error. (We're using graphql-pro, perhaps that has some bearing on things.)

It would likely be hard to make all this code thread-safe. I think it would be a sensible solution for GraphQL::Railtie to ensure that the schema definition is generated up-front when Rails' eager-loading occurs. (Which is effectively what we're doing with the workaround that has been suggested, except it's also happening when eager-loading is not used too.)

jonleighton picture jonleighton on 14 Aug 2018
👍3

Thanks for the write-up! I was also thinking a thread-safety issue.

@jonleighton in the case of:

if I do MySchema.types["MyType"] == MyTypeDefinition I get a false

is MyTypeDefinition a class? If so, you could try: 

MySchema.types["MyType"] == MyTypeDefinition.graphql_definition

.graphql_definition converts the (new-style) class to a (legacy-style) GraphQL::ObjectType instance. (Actually, it returns the cached value of that conversion.)

My guess is that, since the _cache_ of .graphql_definition on each type is not threadsafe, that each type class is being converted on each thread, then _those_ values don't match.

Sometime this year, I want to refactor the legacy-style type objects out of the system, so that's how I plan to solve this problem.

I think we never noticed it at GitHub because of how we use GraphQL-Client. It forces the schema to be eagerly loaded, like you mentioned using a Railtie to do.

rmosolgo picture rmosolgo on 14 Aug 2018

We were just having this issue with a new production launch, every time we'd restart the server a few minutes later we'd have calamitous uprising of 500 errors. Pushed the warmup workaround and it hasn't been a problem since. Maybe this could be automated somehow until the thread safety issue is resolved?

bbugh picture bbugh on 6 Sep 2018

automated somehow

I don't know _how_! When would that method be run that you can be sure the schema is totally defined?

We could bust & rebuild the cache after _every_ configuration method but that would be very slow for large schemas.

In the longer term, I'm trying to rebuild execution (#1394) in such a way that these various caches are not required.

rmosolgo picture rmosolgo on 6 Sep 2018

I proposed a way above:

I think it would be a sensible solution for GraphQL::Railtie to ensure that the schema definition is generated up-front when Rails' eager-loading occurs.

jonleighton picture jonleighton on 7 Sep 2018
👍6

This issue also exists in the Decidim platform in the development environment when the application's constants are being reloaded.

Further details on how to replicate are available here: https://github.com/decidim/decidim/issues/4202

ahukkanen picture ahukkanen on 29 Sep 2018

FYI if you're using the Schema.graphql_definition prewarming trick (which works great) you have to put it after any plugin setup you use (like graphql-errors in our specific case), or it won't work.

Save yourself the headache and just make sure that the trick is after everything else.

No good 馃憥

LampsappSchema.graphql_definition # This has to be below any other setup

GraphQL::Errors.configure(Schema) do
  rescue_from ActiveRecord::RecordNotFound do |_exception, _object, _arguments, context|
    context.add_error GraphQL::ExecutionError.new("Not Found", options: { code: 404 })
  end
end

Hurray it works! 馃憤

GraphQL::Errors.configure(Schema) do
  rescue_from ActiveRecord::RecordNotFound do |_exception, _object, _arguments, context|
    context.add_error GraphQL::ExecutionError.new("Not Found", options: { code: 404 })
  end
end

LampsappSchema.graphql_definition
bbugh picture bbugh on 10 Oct 2018
👍6 ❤1 🎉1

hi, I'm also experiencing that issue, which happens in production (at clever-cloud.com), using nginx and up to date ruby. Here's the stacktrace. I do have puma configured with threads. It's happening randomly, rarely but regularly.

I have yet to try the .graphql_definition trick.

Though, one thing is unclear to me: where should I put that trick?

guyzmo picture guyzmo on 2 Dec 2018
👀1

We've also experienced this issue intermittently. We're all-in on 1.8 syntax and running on ruby 2.5.1 in heroku with puma configured for threads only. We've only seen it in deployed environments, not in development, and we've only seen it a handful of times ever - usually just after a deploy.

We had attempted a pre-warming trick in a rails initializer previously but now I see why that exploded immediately 馃檭 , will try pre-warming in the schema definition instead.

simoleone picture simoleone on 4 Dec 2018

I run into this today in development of a new project:

Duplicate type definition found for name 'UpdatePayload' at 'Field Mutation.updateTraining's return type' (#<Class:0x00007f8c1e2bdd90>, #<Class:0x00007f8c1e2aa150>)
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:168:in `visit'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:205:in `visit_field_on_type'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:185:in `block in visit_fields'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:184:in `each'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:184:in `visit_fields'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:143:in `visit'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:124:in `block in visit'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:124:in `each'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:124:in `visit'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/traversal.rb:43:in `initialize'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema.rb:1059:in `new'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema.rb:1059:in `rebuild_artifacts'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema.rb:740:in `to_graphql'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema/member/accepts_definition.rb:120:in `to_graphql'
/home/o/.rvm/gems/ruby-2.4.4/gems/graphql-1.8.11/lib/graphql/schema.rb:678:in `graphql_definition'
/home/o/.rvm/rubies/ruby-2.4.4/lib/ruby/2.4.0/forwardable.rb:223:in `execute'
/home/o/ruby/stayfit/bfit/app/controllers/graphql_controller.rb:10:in `execute'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/abstract_controller/base.rb:194:in `process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_controller/metal/rendering.rb:30:in `process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/callbacks.rb:132:in `run_callbacks'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/abstract_controller/callbacks.rb:41:in `process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_controller/metal/rescue.rb:22:in `process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/notifications.rb:168:in `block in instrument'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/notifications.rb:168:in `instrument'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_controller/metal/instrumentation.rb:32:in `process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_controller/metal/params_wrapper.rb:256:in `process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/activerecord-5.2.1.1/lib/active_record/railties/controller_runtime.rb:24:in `process_action'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/abstract_controller/base.rb:134:in `process'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionview-5.2.1.1/lib/action_view/rendering.rb:32:in `process'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_controller/metal.rb:191:in `dispatch'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_controller/metal.rb:252:in `dispatch'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/routing/route_set.rb:52:in `dispatch'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/routing/route_set.rb:34:in `serve'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/journey/router.rb:52:in `block in serve'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/journey/router.rb:35:in `each'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/journey/router.rb:35:in `serve'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/routing/route_set.rb:840:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/tempfile_reaper.rb:15:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/etag.rb:25:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/conditional_get.rb:38:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/http/content_security_policy.rb:18:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/session/abstract/id.rb:232:in `context'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/session/abstract/id.rb:226:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/cookies.rb:670:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/activerecord-5.2.1.1/lib/active_record/migration.rb:559:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/callbacks.rb:98:in `run_callbacks'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/callbacks.rb:26:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/executor.rb:14:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/debug_exceptions.rb:61:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/web-console-3.7.0/lib/web_console/middleware.rb:135:in `call_app'
/home/o/.rvm/gems/ruby-2.4.4/gems/web-console-3.7.0/lib/web_console/middleware.rb:30:in `block in call'
/home/o/.rvm/gems/ruby-2.4.4/gems/web-console-3.7.0/lib/web_console/middleware.rb:20:in `catch'
/home/o/.rvm/gems/ruby-2.4.4/gems/web-console-3.7.0/lib/web_console/middleware.rb:20:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/railties-5.2.1.1/lib/rails/rack/logger.rb:38:in `call_app'
/home/o/.rvm/gems/ruby-2.4.4/gems/railties-5.2.1.1/lib/rails/rack/logger.rb:26:in `block in call'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/tagged_logging.rb:71:in `block in tagged'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/tagged_logging.rb:28:in `tagged'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/tagged_logging.rb:71:in `tagged'
/home/o/.rvm/gems/ruby-2.4.4/gems/railties-5.2.1.1/lib/rails/rack/logger.rb:26:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/sprockets-rails-3.2.1/lib/sprockets/rails/quiet_assets.rb:13:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/request_id.rb:27:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/runtime.rb:22:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1.1/lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/executor.rb:14:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/actionpack-5.2.1.1/lib/action_dispatch/middleware/static.rb:127:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-2.0.6/lib/rack/sendfile.rb:111:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/webpacker-3.5.5/lib/webpacker/dev_server_proxy.rb:22:in `perform_request'
/home/o/.rvm/gems/ruby-2.4.4/gems/rack-proxy-0.6.5/lib/rack/proxy.rb:57:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/railties-5.2.1.1/lib/rails/engine.rb:524:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/puma-3.12.0/lib/puma/configuration.rb:225:in `call'
/home/o/.rvm/gems/ruby-2.4.4/gems/puma-3.12.0/lib/puma/server.rb:658:in `handle_request'
/home/o/.rvm/gems/ruby-2.4.4/gems/puma-3.12.0/lib/puma/server.rb:472:in `process_client'
/home/o/.rvm/gems/ruby-2.4.4/gems/puma-3.12.0/lib/puma/server.rb:332:in `block in run'
/home/o/.rvm/gems/ruby-2.4.4/gems/puma-3.12.0/lib/puma/thread_pool.rb:133:in `block in spawn_thread'
Completed 500 Internal Server Error in 56ms (Views: 2.9ms | ActiveRecord: 0.0ms)

I found out the cause was having mutation classes with the same name in different modules:

module Types
  class MutationType < Types::BaseObject

    field :update_user, :mutation => ::Mutations::Users::Update
    field :update_training, :mutation => ::Mutations::Trainings::Update
  end
end

The problem went away when I changed the class names:

module Types
  class MutationType < Types::BaseObject

    field :update_user, :mutation => ::Mutations::Users::UpdateUser
    field :update_training, :mutation => ::Mutations::Trainings::UpdateTraining
  end
end
xprazak2 picture xprazak2 on 21 Dec 2018
👍7

@xprazak2 I'm seeing this atm too, but not with conflicting class names.

jufemaiz picture jufemaiz on 23 Dec 2018

Also experiencing this after switching to class-based syntax. We also debugged this enough to have a strong suspicion of race conditions and/or cache pollution of the types cache...

bjeanes picture bjeanes on 26 Dec 2018

I'm also seeing this problem in a fresh deployment with Dokku. I added MySchema.graphql_definition below the schema declaration (with mutation, query, subscription) and i'll be testing it in production.

This is really a pain as the site basically works and crashes after a while for me.

Loschcode picture Loschcode on 5 Jun 2019

I observed this too. Running on Heroku.

RuntimeError: Duplicate type definition found for name 'FooTask'

Environment:
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-linux]
graphiql-rails (1.7.0) (pro version) 

module Types
   class AdminOrderType < Types::BaseObject
   ...
     class FooTaskType < Types::BaseObject
       ...
      end

     field :fooTask, type: FooTaskType, null: true, method: :fooTask
     field :barTask, type: FooTaskType, null: true
davidw picture davidw on 29 Jun 2019
👍8

Same here, issue happens on heroku when booting up a new dyno.

We are using the gem version 1.8.x, and we had the old DSL type definition api in place. After many tests we found out that migrating to the class based api would solve the issue, so we sped up the whole api migration and we rarely get the issue anymore, but we still do.

A few characteristics of the issue on our side:

  • Once a dyno boots with this error, every graphql request it tries to handle keep outputting the same error message;
  • The issue is more likely to happen during higher throughput periods, suggesting race conditions are in place (this makes the error more likely when we're scaling dynos up to handle traffic spikes, which is quite troubling);
  • Restarting the dyno may solve the issue (although during peak times the dyno keeps restarting with the error);
  • We are running a single puma process per dyno with up to 12 workers per process;
  • Increasing the number of dynos decreases the probability that one new additional dyno will present the issue. I believe this reinfoirces the argument regarding race condition, since more dynos would make it is less likely that two puma threads of the booting-up dyno would process two requests at the same time);
  • We use apollo on the frontend, which is known to perform lots of introspection queries at page load.
  • I have seen the error happening on introspection queries, but not exclusively.

I hope this helps.

khamusa picture khamusa on 4 Oct 2019

Hi @khamusa, thanks for the detailed report.

12 workers per process

Especially since you're running a threaded server, I agree that it's a race condition. Just to confirm, do you still experience this issue after adding graphql_definition to the bottom of your schema class? For example:

class MySchema < GraphQL::Schema 
  # ... 

  # force the schema to completely boot: 
  graphql_definition 
end

I would _expect_ that to load all the types _before_ spinning up worker threads, but I'm interested to hear what your experience has been.

I'm hoping to eliminate the lazy schema boot entirely with #2363 -- I've currently got GitHub's tests passing with that branch, and I'm checking out the performance implications. I hope that branch will cause the whole schema to be loaded as the file is loaded by Ruby, eliminating any runtime race conditions. (It still requires a single-threaded application load -- but I think _all_ Ruby code basically requires that.)

rmosolgo picture rmosolgo on 4 Oct 2019

We've just run into this for the first time, in production only, after using GraphQL for a long while (a year?). Can't reproduce locally. One of our servers restarted and started exhibiting this issue, which went away after forcing a restart. The stack trace is very similar to what others have shared, but I append it below in case there is some extra info to be gleaned for it.

We are also running on Heroku, with Puma configured to use 10 threads. We upgraded from Ruby 2.3 to 2.6 a few weeks ago, and I'm wondering if that makes this issue more prominent. I will be trying the .graphql_definition workaround to see if helps for now.

@rmosolgo I see that you have already merged https://github.com/rmosolgo/graphql-ruby/pull/2363 . Do you have a sense of when it will be released in a stable version? Will there be an update on this issue when that's available to try?

Full stack trace:

File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 168 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 205 in visit_field_on_type
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 185 in block in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 184 in visit_fields
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 143 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 124 in block in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 124 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 124 in visit
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/traversal.rb" line 43 in initialize
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema.rb" line 1037 in new
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema.rb" line 1037 in rebuild_artifacts
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema.rb" line 272 in types
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/possible_types.rb" line 16 in initialize
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema.rb" line 182 in new
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema.rb" line 182 in initialize_copy
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/define/instance_definable.rb" line 129 in initialize_dup
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/define/instance_definable.rb" line 129 in dup
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/define/instance_definable.rb" line 129 in redefine
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema.rb" line 730 in to_graphql
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema/member/accepts_definition.rb" line 120 in to_graphql
File "/app/vendor/bundle/ruby/2.6.0/gems/graphql-1.8.8/lib/graphql/schema.rb" line 678 in graphql_definition
File "/app/vendor/ruby-2.6.4/lib/ruby/2.6.0/forwardable.rb" line 224 in execute
File "/app/app/controllers/graphql_controller.rb", line 13 in execute
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_controller/metal/basic_implicit_render.rb" line 4 in send_action
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/abstract_controller/base.rb" line 188 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/scout_apm-2.4.14/lib/scout_apm/instruments/action_controller_rails_3_rails4.rb" line 72 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_controller/metal/rendering.rb" line 30 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/abstract_controller/callbacks.rb" line 20 in block in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 126 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 506 in block (2 levels) in compile
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 455 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 101 in __run_callbacks__
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 750 in _run_process_action_callbacks
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 90 in run_callbacks
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/abstract_controller/callbacks.rb" line 19 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_controller/metal/rescue.rb" line 20 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_controller/metal/instrumentation.rb" line 32 in block in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/notifications.rb" line 164 in block in instrument
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/notifications/instrumenter.rb" line 21 in instrument
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/notifications.rb" line 164 in instrument
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_controller/metal/instrumentation.rb" line 30 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_controller/metal/params_wrapper.rb" line 248 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/activerecord-5.0.7.2/lib/active_record/railties/controller_runtime.rb" line 18 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/scout_apm-2.4.14/lib/scout_apm/instruments/action_controller_rails_3_rails4.rb" line 83 in process_action
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/abstract_controller/base.rb" line 126 in process
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_controller/metal.rb" line 190 in dispatch
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_controller/metal.rb" line 262 in dispatch
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/routing/route_set.rb" line 50 in dispatch
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/routing/route_set.rb" line 32 in serve
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/journey/router.rb" line 39 in block in serve
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/journey/router.rb" line 26 in each
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/journey/router.rb" line 26 in serve
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/routing/route_set.rb" line 727 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/scout_apm-2.4.14/lib/scout_apm/instruments/rails_router.rb" line 29 in call_with_scout_instruments
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/omniauth-1.6.1/lib/omniauth/strategy.rb" line 189 in call!
File "/app/vendor/bundle/ruby/2.6.0/gems/omniauth-1.6.1/lib/omniauth/strategy.rb" line 167 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/omniauth-1.6.1/lib/omniauth/builder.rb" line 63 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/scout_apm-2.4.14/lib/scout_apm/middleware.rb" line 17 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/rack/agent_hooks.rb" line 30 in traced_call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/rack/browser_monitoring.rb" line 32 in traced_call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/app/middleware/jwt_authentication.rb", line 41 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/etag.rb" line 25 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/conditional_get.rb" line 38 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/head.rb" line 12 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/session/abstract/id.rb" line 232 in context
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/session/abstract/id.rb" line 226 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/cookies.rb" line 613 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/callbacks.rb" line 38 in block in call
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 97 in __run_callbacks__
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 750 in _run_call_callbacks
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb" line 90 in run_callbacks
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/callbacks.rb" line 36 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/remote_ip.rb" line 79 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rollbar-2.16.2/lib/rollbar/middleware/rails/rollbar.rb" line 24 in block in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rollbar-2.16.2/lib/rollbar.rb" line 146 in scoped
File "/app/vendor/bundle/ruby/2.6.0/gems/rollbar-2.16.2/lib/rollbar/middleware/rails/rollbar.rb" line 22 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/debug_exceptions.rb" line 49 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rollbar-2.16.2/lib/rollbar/middleware/rails/show_exceptions.rb" line 22 in call_with_rollbar
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/show_exceptions.rb" line 31 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/railties-5.0.7.2/lib/rails/rack/logger.rb" line 36 in call_app
File "/app/vendor/bundle/ruby/2.6.0/gems/railties-5.0.7.2/lib/rails/rack/logger.rb" line 24 in block in call
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/tagged_logging.rb" line 69 in block in tagged
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/tagged_logging.rb" line 26 in tagged
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/tagged_logging.rb" line 69 in tagged
File "/app/vendor/bundle/ruby/2.6.0/gems/railties-5.0.7.2/lib/rails/rack/logger.rb" line 24 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/request_id.rb" line 24 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/method_override.rb" line 22 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/runtime.rb" line 22 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/activesupport-5.0.7.2/lib/active_support/cache/strategy/local_cache_middleware.rb" line 28 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/executor.rb" line 12 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/static.rb" line 136 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/sendfile.rb" line 111 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/actionpack-5.0.7.2/lib/action_dispatch/middleware/ssl.rb" line 84 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/hirefire-resource-0.4.2/lib/hirefire/middleware.rb" line 41 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/rack-cors-1.0.2/lib/rack/cors.rb" line 97 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/scout_apm-2.4.14/lib/scout_apm/instruments/middleware_summary.rb" line 58 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/railties-5.0.7.2/lib/rails/engine.rb" line 522 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/newrelic_rpm-4.2.0.334/lib/new_relic/agent/instrumentation/middleware_tracing.rb" line 92 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/puma-3.12.1/lib/puma/configuration.rb" line 227 in call
File "/app/vendor/bundle/ruby/2.6.0/gems/puma-3.12.1/lib/puma/server.rb" line 660 in handle_request
File "/app/vendor/bundle/ruby/2.6.0/gems/puma-3.12.1/lib/puma/server.rb" line 474 in process_client
File "/app/vendor/bundle/ruby/2.6.0/gems/puma-3.12.1/lib/puma/server.rb" line 334 in block in run
anaulin picture anaulin on 28 Oct 2019

We've gotten this on staging & prod environments, hosted on Heroku.

Ruby environment

ruby '2.5.7'
gem 'rails', '5.2.3'
gem 'puma', '3.12.0'
gem 'pg', '1.1.3'
gem 'graphql', '1.8.10'

Staging:

  • 1 Puma worker; 2 threads min, 6 max
    .

    Prod

  • 2 web dynos

  • 1 Puma worker, 4 threads min, 12 max

The errors have only occurred immediately after a successful deploy, after the first query is parsed & attempts execution. On prod it was initially difficult to debug since the error was only happening in 1 dyno -- the other was completely fine.

Went through the pains of upgrading every GQL Type to class-based, thinking the issue was the combination of the old & new syntaxes.

Since others seem to have success adding MySchema.graphql_definition after schema definition, we'll attempt this solution in the meantime.

From previous replies, this seems to be a multi-threaded issue... Can we expect #2363 to resolve this by v1.10?

fire-pls picture fire-pls on 30 Oct 2019

@fire-pls

Can we expect #2363 to resolve this by v1.10?

According to this comment, yes: https://github.com/rmosolgo/graphql-ruby/issues/2018#issuecomment-545470568

nehresma picture nehresma on 6 Nov 2019
🎉1

Hi every one, I have the same issue
"message": "Duplicate type definition found for name 'Show' at 'Field Index.messages's return type' (Types::User::Show, Types::Message::Show)",

and have any idea can fixed then?
by the way how can i upgrade version to 1.10.0-dev in my Gemfile?

@rmosolgo help me please ~

roc26002w picture roc26002w on 14 Nov 2019
👍2

@roc26002w , GraphQL's default type name is based on the _last part of the class name_. For the two classes you defined (Types::User::Show and Types::Message::Show), GraphQL is inferring Show as the type name.

Specify a unique name using graphql_name("MessageShow"), for example, in the class definition.

Alternatively, override self.default_graphql_name in a base class to provide new logic for building a default name.

rmosolgo picture rmosolgo on 12 Feb 2020

Hey, I think this issue can be fixed on 1.10, if:

  • The schema is all migrated to class-based definitions

  • New modules are used: 

    class MySchema < GraphQL::Schema 
use GraphQL::Execution::Interpreter 
use GraphQL::Analysis::AST 
end

In that setup, GraphQL-Ruby's approach to identifying the types in a schema is brand new, and much simpler. The specific case in #2448 is fixed, for example.

As a matter of housekeeping, I'm going to close this issue. If you try the approach I described above and still encounter this issue, please open a new issue with the full backtrace and a description of how you encountered the problem.

If you try to migrate and run into trouble, please open an issue for that! Thanks so much for your patience and help in debugging this. I think there's light at the end of the tunnel! 馃

rmosolgo picture rmosolgo on 12 Feb 2020
👍6 ❤2 🚀1 🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

dsgoers picture dsgoers  路  3Comments
rylanc picture rylanc  路  3Comments
dmc2015 picture dmc2015  路  3Comments
sayduck-daniel picture sayduck-daniel  路  3Comments
gastonmorixe picture gastonmorixe  路  3Comments