Graphql-playground: SaveSettings handler broken in version 1.7.21

Created on 11 Apr 2020  路  4Comments  路  Source: graphql/graphql-playground

This issue pertains to the following package(s):

  • [ ] GraphQL Playground - Electron App
  • [ ] GraphQL Playground HTML
  • [ ] GraphQL Playground
  • [ x] GraphQL Playground Express Middleware
  • [ ] GraphQL Playground Hapi Middleware
  • [ ] GraphQL Playground Koa Middleware
  • [ ] GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?

MacOS Catalina

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

1.7.21

What is the expected behavior?

saveSettings handler should allow for settings to be saved...

What is the actual behavior?

SaveSettings handler should fire correctly and save my settings...

What steps may we take to reproduce the behavior?

install latest package, launch playground, open dev tools, go to settings, change any settings press command+s or click saveSettings button . saveSettings handler is not a function.
If i hard code in version 1.7.9 (first version i tested) into the script tag inside the render-playground-page.js file the error is resolved.

_Please provide a gif or image of the issue for a quicker response/fix._
Screen Shot 2020-04-10 at 10 40 41 PM

bu1-repro-available bu2-confirmed

All 4 comments

@binoy14 @beeman is this something we forgot to test in the last release? Hmmm

image

thanks for reporting @elektro1103! confirmed on netlify

In fact, I can't seem to find when this was last set up properly in master. looks like this prop handler has been missing for a while, looking at PlaygroundWrapper.tsx more closely

Thanks guys !! appreciate the quick fix!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

miketmoore picture miketmoore  路  4Comments

kbrandwijk picture kbrandwijk  路  3Comments

schickling picture schickling  路  3Comments

tobkle picture tobkle  路  4Comments

nikcorg picture nikcorg  路  3Comments