Graphql-playground: Can not install graphql-playground-react via npm proxy (depends on direct github package)

[matthewwiesen]

This issue pertains to the following package(s):

• [ ] GraphQL Playground - Electron App
• [ ] GraphQL Playground HTML
• [ ] GraphQL Playground
• [ ] GraphQL Playground Express Middleware
• [ ] GraphQL Playground Hapi Middleware
• [ ] GraphQL Playground Koa Middleware
• [ ] GraphQL Playground Lambda Middleware
• [x] GraphQL Playground React

What OS and OS version are you experiencing the issue(s) on?

Any OS

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

graphql-playground-react 1.7.10

What is the expected behavior?

Install / obtain versioned dependencies via npm package registry

What is the actual behavior?

Current package.json relies on installing specific branch of a github repository:

• https://github.com/prisma/graphql-playground/blob/740a66ba67714c47c48b32253829ba648e136e06/packages/graphql-playground-react/package.json#L113

This works normally where one has direct access to the internet, however, typically behind corporate networks direct connections to github such as this are blocked and npm packages are typically proxied / cached into the environment since they are immutable with static dependencies.

Installing directly from a repo by pulling the latest commit off a branch means that one can not reliabily ensure the same version is installed overtime. Even if one were depending upon a specific git sha commit from a repo could be removed via a rebase / rewrite of git history, thus why installing from git repos is generally not a good idea when one must ensure reliably rebuilding packages / dependencies.

What steps may we take to reproduce the behavior?

Review package.json depending on github repository:

• https://github.com/prisma/graphql-playground/blob/740a66ba67714c47c48b32253829ba648e136e06/packages/graphql-playground-react/package.json#L113

Steps to resolve

Review upstream package if it is possible to no longer depend on forked version.. or if this is not possible, publish the forked dependency to npm and update package.json dependency to pull from this scoped fork.. or directly include the forked codebase within this package to be depended upon.

[douglasmuraoka]

@timsuchanek is the reason to use the forked version still valid? If yes, could you please publish it on npm? I'm sure that would help a lot of people, including us from Parse :)

It would also resolve #1006 #1052

[kikar]

Any news?