Graphql-js: Issues with ScalarLeafs validation rule?

Created on 13 Apr 2017  路  7Comments  路  Source: graphql/graphql-js

Seeing issues like:

Expected at least one selection for non-scalar field `id` on type `ID!`.

In v0.9.2 and v0.9.3

bug help wanted
Source
picture leebyron
😕1

Most helpful comment

well thanks for the eyesect

picture leebyron on 14 Apr 2017
😄2

All 7 comments

@wincent could you help with this? Repos when running Relay tests after upgrading to the latest version of graphql

leebyron picture leebyron on 13 Apr 2017

Yep, will check it out.

wincent picture wincent on 13 Apr 2017
❤1

This is caused by 12b2137f8a0b1a72752b.

wincent picture wincent on 14 Apr 2017

Oh awesome thanks for the bisect, I know exactly how to fix this now!

leebyron picture leebyron on 14 Apr 2017

Ha, it wasn't a bisect. I eyeballed the commit history and this commit was my first guess, testing confirmed it was the cause.

wincent picture wincent on 14 Apr 2017

well thanks for the eyesect

leebyron picture leebyron on 14 Apr 2017
😄2

This was my mistake for looking for an issue within validation, on closer inspection this issue was just contained within Relay. I'm going to close this issue in favor of https://github.com/facebook/relay/pull/1611

leebyron picture leebyron on 15 Apr 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

galki picture galki  路  3Comments
vslinko picture vslinko  路  4Comments
hekike picture hekike  路  4Comments
swist picture swist  路  4Comments
davide-ganito picture davide-ganito  路  4Comments