Graphql-code-generator: Use dependency ranges in package.json

Created on 8 Mar 2020  路  5Comments  路  Source: dotansimha/graphql-code-generator

Is your feature request related to a problem? Please describe.

Recently, after updating the dependencies of my project, I noticed that some packages loaded many times.
You may look at this example https://github.com/standy/starwars-graphql-example
[email protected] is loaded 20 times only for 3 plugins!

As docs for renovatebot say: libraries should use dependency ranges https://docs.renovatebot.com/dependency-pinning/#ranges-for-libraries.

bad idea to pin all your dependencies because it will introduce an unnecessarily narrow range (one release!) and cause most users of your package to bloat their node_modules with duplicates

Describe the solution you'd like
Remove renovate bot

core enhancement waiting-for-release

All 5 comments

@ardatan @kamilkisiela what do you think?

Any answer will be appreciated 馃憢

Npm packages are using semver, so unpinning is safe. Take a look into other big libraries, no one is pinning:
https://github.com/facebook/react
https://github.com/babel/babel
https://github.com/infernojs/inferno
https://github.com/rollup/rollup
https://github.com/webpack/webpack

Yeah, pinning should be done only on our packages

I did it partially for now, will improve later.

Fixed in v1.13.2

Was this page helpful?
0 / 5 - 0 ratings