Graphiql: add test suite to monaco-graphql

Created on 30 Jun 2020  路  8Comments  路  Source: graphql/graphiql

our beloved monaco-graphql _could_ have a really nice test suite!

monaco-yaml's suite provides a fantastic example

we can just start with something similar to the hover/completion/diagnostics suites. we don't need to worry about multiple documents or completion with multiple schemas any time soon

good first issue monaco

All 8 comments

Hey, I'm a recent starter and would be interested in knowing about this issue and working on it!

great to hear, @faraz16iqbal , that would be great to have help with. have you worked with jest or any other test runner before?

Nope, unfortunately I haven't. But I'll be more than thrilled to look and work into it!

Hey @acao 馃憢

If you haven't assigned this issue to anyone yet, then I would like to know more about it and would be interested in taking up this issue.

Thanks

@iamdarshshah that would be great, I have assigned in the past, but no one has taken it up yet.

i don't have many more details than whats in the description, and I'm on vacation, but just setting up the harness and a test file or two for language features, schema loading, etc would be a great start!

Hey @acao

Will be happy to take this issue and start working on it asap. Also, you mentioned about monaco-yaml's suite example before, it seems the link is not working (can you please update it for better understanding).

It would be great if you provide a summary of what things we are planning to include in monaco-graphql test suite. I'm pretty new to this and it would be a great help if you guide me with what things we should start it with. As you mentioned about the test files for language features and schema loading, If I'm understanding it correctly, we need to create a test suite for each file in monaco-graphql directory, right? If so, then as you have mentioned will start with setting up the harness and language-features file.

Would like to know your thoughts on this.

Thanks

@iamdarshshah sadly, it seems like they took their test suite away since I created this ticket a few months ago!

because of that, and changes to the architecture of the monaco-graphql plugin itself, I'm going to be introducing a suite soon, and I'll be sure to give you a good starting point to test very specific features

@acao Looking forward to it. Thanks 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

intellix picture intellix  路  10Comments

asiandrummer picture asiandrummer  路  12Comments

fson picture fson  路  17Comments

OlegIlyenko picture OlegIlyenko  路  17Comments

sashahavia picture sashahavia  路  50Comments