Graphiql: React duplicate key warning in QueryHistory component since 0.16.0

[MichaelBurgess]

Since upgrading to 0.16.0 I'm getting duplicate key warnings from the QueryHistory component. I have a few of the same items in the history - this looks to be the issue here: https://github.com/graphql/graphiql/blob/87e9d465b51487d41f03e7c09eda5d2e7116e1cb/packages/graphiql/src/components/QueryHistory.js#L96

0.chunk.js:319590 Warning: Encountered two children with the same key, `mutation SomeMutation($input: SomeMutationInput!) {
  someMutation(input: $input) {
    result
  }
}`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
    in ul (created by QueryHistory)
    in section (created by QueryHistory)
    in QueryHistory (created by GraphiQL)
    in div (created by GraphiQL)
    in div (created by GraphiQL)

[MickaelNeves]

Getting the same problem

[acao]

About to take care of this in the upgrade to react 16 this week. Thanks for
reporting it!

On Mon, Oct 28, 2019 at 8:38 AM Mickael Neves [e-mail]
wrote:

Getting the same problem

[image: console]
https://user-images.githubusercontent.com/20476271/67678886-aa030c00-f97f-11e9-9b8e-d55cdb5cd020.PNG

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/graphql/graphiql/issues/988?email_source=notifications&email_token=AAKOFFYJOZCV5UQJEF6Z5B3QQ3MKZA5CNFSM4JFYMB6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECMXGOY#issuecomment-546927419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKOFF3FAB6OA6NO6AMCDWTQQ3MKZANCNFSM4JFYMB6A
.

[moroshko]

@acao Any luck?

[acao]

@moroshko ah dangit my bad, forgot to bring this into the 0.17.0 release. this is a bad bug, and we need to fix it immediately! I will get on a 0.17.1 bugfix release today, much smaller effort.

[acao]

@moroshko able to give this a try to confirm? looks like this fixes the bug:

[moroshko]

@acao Thanks for fixing this, let's release the fix!

[acao]

@moroshko we have a few more PRs waiting for the next release, one in particular that fixes our minified build. our latest published one is provisional from that PR. our minified builds are the most widely used. so hopefully later this week!