Graphene: Parameterized mutation sent with an Apollo Client

[dbrrt]

Is there any support for Apollo Client ? It doesn't seem to handle properly variables sent from an Apollo mutation on the client.

    def mutate(self, info, name):
        category = Category(name=name)
        return CreateCategory(category=category)

[jkimbo]

@dbrrt is this still an issue for you?

[dbrrt]

@jkimbo Yes, I temporarily switched to a nodejs back-end

[jkimbo]

That's a shame. Can you give any more details so I could reproduce the error?

[dbrrt]

https://github.com/dbrrt/apollo-aiohttp-graphene

You can start client using yarn and yarn start
and server with make

I'm calling mutation with Apollo in : https://github.com/dbrrt/apollo-aiohttp-graphene/blob/master/client/components/views/Home/mut.js

It works using GraphiQL, so the problem might be related to Apollo client directly.

[jkimbo]

@dbrrt I found the issue and fixed it in https://github.com/dbrrt/apollo-aiohttp-graphene/pull/1

Basically the schema execute function needed the variable values that were being sent by Apollo.

[jkimbo]

BTW you can see how graphene-django executes the query here: https://github.com/graphql-python/graphene-django/blob/a480a39713d3392dc3a7cee9565989a713d05856/graphene_django/views.py#L263-L271

[freyley]

@jkimbo I'm having what may be the same issue, but the linked repo is now unavailable. @jkimbo can you recall what you suggested in your PR?

[jldillman]

@freyley I think I'm having the same issue with React-Apollo and Graphene 2.1.8:

query {
    formFieldsByNoteType(noteType: DAILY_NOTE) {
        mnemonic
    }
}

That works just fine and returns this response:

{
    "data": {
        "formFieldsByNoteType": [
            {
                "mnemonic": ...

But this query:

query FormFieldsByNoteType($noteTypeParam: NoteType!) {
    formFieldsByNoteType(noteType: $noteTypeParam) {
      mnemonic
    }
  }

with the variables {"noteTypeParam": "DAILY_NOTE"} provided using Postman returns this response:

{
    "data": null,
    "errors": [
        {
            "message": "Variable \"$noteTypeParam\" of required type \"NoteType!\" was not provided.",
            "locations": [
                {
                    "line": 1,
                    "column": 28
                }
            ]
        }
    ]
}

@jkimbo I think my Graphene implementation probably makes the same error that you fixed in that PR to @dbrrt's repo, which is now private. Can you clarify how you fixed this?

[jldillman]

Also @dbrrt would you be able to post the changes @jkimbo included in the PR to your repo you made private? It would be a huge help.

[dbrrt]

@jldillman Absolutely. Here's the schema

# schema.py

import random
import asyncio
import graphene

class CreatePerson(graphene.Mutation):
    class Arguments:
        name = graphene.String()

    ok = graphene.Boolean()
    person = graphene.Field(lambda: Person)

    def mutate(self, info, name):
        person = Person(name=name)
        ok = True
        return CreatePerson(person=person, ok=ok)


class Person(graphene.ObjectType):
    name = graphene.String()
    age = graphene.Int()

class MyMutations(graphene.ObjectType):
    create_person = CreatePerson.Field()

# We must define a query for our schema
class Query(graphene.ObjectType):
    person = graphene.Field(Person)

schema = graphene.Schema(query=Query, mutation=MyMutations)

If I remember correctly, I omitted to pass the data in graphql_post method, here was a working version

# in main.py
async def graphql_post(request):
    payload = await request.json()
    response = await schema.execute(
        payload.get('query', ''),
        variable_values=payload.get('variables', None),
        return_promise=True
    )
    data = {}
    if response.errors:
        data['errors'] = [format_error(e) for e in response.errors]
    if response.data:
        data['data'] = response.data
    jsondata = json.dumps(data,)
    return web.Response(text=jsondata, headers={'Content-Type': 'application/json'})

[jldillman]

@dbrrt Thank you so much! Your last snippet was _exactly_ what I needed to see. Turns out our naive implementation of a request handler was only passing the query part of the request, and leaving the variable_values parameter empty. My afternoon of troubleshooting was now worth it. Thanks again!