Graphback: Improve documentation for our templates (mainly readme.md)

Created on 8 Sep 2020  路  23Comments  路  Source: aerogear/graphback

Documentation should contain basic information about what is the picked technology: express.
What is the GraphQL technology. Apollo etc. What tools are required before development (codegen, graphback generate) and how they work into complete development workflow.

Current readme has this info but it needs to be extended.

bug good first issue templates docs Hacktoberfest

Most helpful comment

Thanks @RinkiyaKeDad for the amazing contributions. Looking forward to many more from you <3

All 23 comments

/cc @craicoverflow, @machi1990
Automatically generated comment to notify maintainers

Hi! I'm new to this repo and would like to work on this issue. Can you point me in the right direction? Apart from the mentioned stuff in the issue what all should I include in the README?

@RinkiyaKeDad Hi. Thanks for reaching out.
Our repo templates contains readme:
https://github.com/aerogear/graphback/tree/master/templates

Readme needs to have more information about what technologies are used for testing, code generation etc. Similairly to https://github.com/facebook/create-react-app

Thanks for responding @wtrocki. As far as I understand the READMEs in all four of the folders need to updated. I'll be starting with the 'ts-react-apollo-client' one first. I'm a bit new to this so would like to confirm that I'm to fork the repo, make the changes in the readme and create a pull request right?

Hey @RinkiyaKeDad! Thanks for offering to help us out! Have you used Graphback before? I would first suggest playing around with Graphback and using the templates to get an understanding of how they work.

Yes, you fork the repo, create a new branch and create a PR!

Hi @craicoverflow! I thought of using Graphback but hesitated since I have never used TypeScript before. But I'll follow your suggestion and try again in order to get a better understanding before I begin updating the README.

Have you used JavaScript before?

Yes I have.

That's great - to use the templates JavaScript knowledge should be sufficient - TypeScript is a superset of JavaScript so they are very similar.

What tools are required before development (codegen, graphback generate) and how they work into complete development workflow.

I have added a section of dependencies in the README where I've briefed about GraphQL, Apollo Client and Material UI. But I'm not quite sure what this line means? I see that there is a generate script in the package.json,
"generate": "graphback generate && graphql codegen"
So from what I understand till now graphback generate is to regenerate the files after some changes have been made. But what is codegen and graphql codegen?

So from what I understand till now graphback generate is to regenerate the files after some changes have been made. But what is codegen and graphql codegen?

Amazing questions! Absolutely love that you have reached out and helped us as this really shows that.. in fact we need better README.md

For graphback generate see:
https://graphback.dev/docs/cli/graphback-cli

For codegen generate see:
https://graphql-code-generator.com/

Thanks a lot @wtrocki! Have gone through them a created a PR for the README of the React Template. Please suggest me what more can I imporve in the README.

Hey before I start working on the other READMEs, I wanted to ask that if something is similar across the templates is it fine if I use the same descriptions or is it prefered to re-write it? Like if lets say another template also uses React then can I copy over what I wrote for React in the previous README?

You can likely reuse some bits of information from the React template around Graphback, but since all the other templates are backend templates, the content will be pretty different overall.

Got it!

Was going through the mongodb template files. yarn generate there too has the same funtionality as far as I could understand, right?

Yep. It was shortcut to not explain complexities of using 2 tools.

So should I use the same explanation?

Yes you can. The best thing to do is create a PR and we can review whether it needs to be adjusted from there.

Fixed by @RinkiyaKeDad - amazing work!

Thanks @RinkiyaKeDad for the amazing contributions. Looking forward to many more from you <3

Thanks :) Will surely be contributing more.

That's great to hear! :+1:

Was this page helpful?
0 / 5 - 0 ratings