Grapesjs: Two devices with same width

[kevinalvarez]

Hi all,
We have an scenario where we need to have two devices with same width. Almost everything works fine, but when we try to change between these devices (same width), the elements from the preview don't answer until we change another device with different size.

Any idea?

Thanks!

[artf]

What do you mean by the elements from the preview don't answer?

[kevinalvarez]

I can't edit the elements, like "read only"

[artf]

@kevinalvarez can't reproduce. Can you create a live demo?

[kevinalvarez]

Look at this demo: https://jsfiddle.net/9w2g8su5/1/
I have 4 devices. General and Desktop have the same width. If I change from General to Desktop (or vice versa), I can't select or edit any component from the canvas until select another device with different width

[ryandeba]

Hi all,

I did a little bit of research into this, I believe the issue starts inside of FrameView.updateDim() when em.stopDefault() is called, which stops select-comp (the default command) until the resizing transition is done. Since the dimensions haven't changed, there is no resize transition, FrameView.updateOffset() never runs so the select-comp command is never started again. In code, this runs, then this runs, and this is expected to run after the transition ends but never does. I don't know what the fix is, but here's a jsfiddle that replicates the issue after 2 seconds (see the setTimeout at the bottom) without messing with the devices at all.

Is calling em.stopDefault() necessary inside FrameView.updateDim()? I'm guessing there's a good reason for it, but I'm not sure what that reason is.

@kevinalvarez - here's a hacky fix if you need to a working solution right now: jsfiddle

[kevinalvarez]

Thanks for the help, @ryandeba ! It worked fine with the code you sent. We can move on :). I hope there can be a fix inside the library.

[artf]

Is calling em.stopDefault() necessary inside FrameView.updateDim()? I'm guessing there's a good reason for it, but I'm not sure what that reason is.

It's there to prevent fixed highlighting box which appears when you hover components during the animation 😬

I'll put a fix which will gonna check on the dimension change otherwise udpateOffset will be triggered immediately

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.