Gqlgen: StartOperationParsing not called on subscriptions

Created on 16 Oct 2019  路  4Comments  路  Source: 99designs/gqlgen

What happened?

I enabled tracing on my gqlgen server which had a Subscription added to it. After doing so I immediately hit https://github.com/99designs/gqlgen-contrib/issues/10 -- which stems from the fact that StartOperationParsing is never called for Subscription calls. It seems that the websocket handler has its own query parsing (separate from the the on in graphql.go which starts the trace).

What did you expect?

I would expect that StartOperationParsing would still be called in subscriptions (since request parsing, etc. still happens).

bug stale

Most helpful comment

We have a big change in #885 .
I think this issue will be fixed in master / HEAD.

All 4 comments

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This is still an issue, so it shouldn't be marked stale

We have a big change in #885 .
I think this issue will be fixed in master / HEAD.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

itsbalamurali picture itsbalamurali  路  4Comments

jwatte picture jwatte  路  4Comments

huanghantao picture huanghantao  路  3Comments

kevinmbeaulieu picture kevinmbeaulieu  路  3Comments

imiskolee picture imiskolee  路  3Comments