Got: Got doesn't throw a timeout error when passing an agent

[shikar]

Describe the bug

• Node.js version: v13.14.0
• OS & version: osx 10.15.6

Timeout option not working with proxy (using tunnel as proxy)

Code to reproduce

got('https://example.com', {
    timeout: 50,
    agent: {
        https: tunnel.httpsOverHttp({
             proxy: {
                 host: '175.44.108.137',
                 port: 9999
            }
        })
    }
})

set agent https to tunnel.httpsOverHttp, got timeout is invalid!!!

[sindresorhus]

timeout is milliseconds, not seconds.

[shikar]

I know timeout is milliseconds!
My question is Timeout option not working with proxy (using tunnel as proxy)

[shikar]

Timeout option is not work, when i add 'proxy agent' option
if i remove 'proxy agent', timeout is work.
but I need them both, and how could i figure it out?

[szmarczak]

https://github.com/nodejs/node/issues/34651

[Scott-Hickmann]

Is there any solution to this bug or an alternative way to timeout a request with a proxy? If not, is a fix planned soon?

[Gameghostify]

Running into this issue as well, if anyone knows of a workaround it would be greatly appreciated

[alvis]

A workaround is to utilise the cancel method with a setTimeout. It won't give you a TimeoutError, but it does the job and throw you an error.

const request = got(options);
const timeout = setTimeout(() => request.cancel(), this.timeout);

const response = await request;
clearTimeout(timeout);

[dodois]

The same problem.

[dodois]

A workaround is to utilise the cancel method with a setTimeout. It won't give you a TimeoutError, but it does the job and throw you an error.

const request = got(options);
const timeout = setTimeout(() => request.cancel(), this.timeout);

const response = await request;
clearTimeout(timeout);

got.cancel is not a function

[alvis]

It's request.cancel, not got.cancel. ;)

[jolivaSan]

Same problem here, what is exactly the reason for that error? the 'request' timeout should start even before trying to connect to the proxy right? why is not working?

[szmarczak]

@jolivaSan https://github.com/sindresorhus/got/issues/1393#issuecomment-670164753