got actually need nodejs >= 10.9, not >= 10

Created on 24 Mar 2020  路  1Comment  路  Source: sindresorhus/got

Describe the bug

  • Node.js version: 10.2
  • OS & version: MacOS

got actually need nodejs >= 10.9, not >= 10

the request function prototype used in GOT was appeared in NodeJS 10.9:

https://github.com/sindresorhus/got/blob/master/source/request-as-event-emitter.ts#L246

https://nodejs.org/docs/latest-v10.x/api/http.html#http_http_request_options_callback

image

Checklist

  • [x] I have read the documentation.
  • [x] I have tried my code with the latest version of Node.js and Got.
question

Most helpful comment

It's expected that users upgrade patch versions of a Node.js minor version. Without doing so, you're leaving yourself unpatched to lots of security issues.

Relevant: https://github.com/sindresorhus/meta/issues/8

We'll bump the version in package.json to >=10.19 (or newer) when we do the next major version of Got.

>All comments

It's expected that users upgrade patch versions of a Node.js minor version. Without doing so, you're leaving yourself unpatched to lots of security issues.

Relevant: https://github.com/sindresorhus/meta/issues/8

We'll bump the version in package.json to >=10.19 (or newer) when we do the next major version of Got.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

carvallegro picture carvallegro  路  4Comments

dominusmars picture dominusmars  路  3Comments

quocnguyen picture quocnguyen  路  4Comments

lukechu10 picture lukechu10  路  3Comments

dAnjou picture dAnjou  路  3Comments