Got: 7.0.0

Created on 6 May 2017  Â·  12Comments  Â·  Source: sindresorhus/got

I'd like for us to do a v7 soonish.

Remaining issues: https://github.com/sindresorhus/got/milestone/5

Any other breaking changes we should get into the release? I'm hoping we won't have to do another major release for a long while, so would be nice to land anything breaking now.

// @floatdrop @AlexTes

✭ help wanted ✭

All 12 comments

@sindresorhus should we wait for #281 in 7.0.0?

@floatdrop It's not a blocker. Just would be nice, as I'd like to have it on by default, which would be a breaking change.

@lukechilds Do you think it will be ready in a couple of weeks? Or should we just defer it to another release?

I would like to say it will be ready in a couple of weeks but I'm waiting to hear back on some client work which will take priority so I can't guarantee anything unfortunately.

Regarding enabling cache by default, I think it'll have to be opt in as we aren't bundling a cache store with Got. To enable caching the user will have to manually install and pass in a cache store:

const got = require('got');
const levelup = require('levelup');
const redisdown = require('redisdown');
const db = levelup('mydb', { db: redisdown, host: 'localhost', port: 6379 });

got('foo.com', {cache: db});

No caching by default so would just be a SemVer minor release.

@lukechilds Alright. No pressure. We can add it in a minor release later on. I don't want to rush this feature.

@sindresorhus looks like it is time to ship. Should something be fixed before?

@floatdrop We need to write a good changelog first. Hop into Gitter.

I just needed to say that options.body being an object instead of a string made my day. Thank you for the awesome module.

@maccelerated Glad you liked that. Do let us know in a new issue if there's anything else that could be improved ;)

@sindresorhus Where is that changelog? I see you're talking about breaking changes but I can't find a list. (Semver of breaking changes since my current version 6.5...)

Thanks!

@avimar releases is where you want to look 😉.
Here's the changelog for v7.0.0.

Thanks, got it! (Was expecting a CHANGELOG file like many projects have now.)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lukehorvat picture lukehorvat  Â·  3Comments

dAnjou picture dAnjou  Â·  3Comments

quocnguyen picture quocnguyen  Â·  4Comments

tkoelpin picture tkoelpin  Â·  3Comments

carvallegro picture carvallegro  Â·  4Comments