Got: Buffer.from causes incompatibility with node 4

Created on 3 Nov 2016  Â·  2Comments  Â·  Source: sindresorhus/got

Buffer.from wasn't added to Node until v5.10.0, so the changes in 5888ca7 caused this to break when running Node 4. I'm thinking the engines in package.json needs to be updated to reflect this?

Most helpful comment

Buffer.from was backported to v4.5.0, so it would be nice if that was the minimum version required.

All 2 comments

Buffer.from was backported to v4.5.0, so it would be nice if that was the minimum version required.

@mmcbride1007 @squarejaw future testing was added in 6.6.2 – should work on 4.x now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

f-mer picture f-mer  Â·  4Comments

dAnjou picture dAnjou  Â·  3Comments

dominusmars picture dominusmars  Â·  3Comments

jamestalmage picture jamestalmage  Â·  3Comments

alanzhaonys picture alanzhaonys  Â·  4Comments