Gophish: .modal-open is not added back to body element

Created on 19 Apr 2017  路  3Comments  路  Source: gophish/gophish

When a nested modal is closed the .modal-open class is removed from the body even though a modal is still open, making it impossible to scroll to view the rest of the modal or press a cancel or save button.

image

I've replicated this through the following submenus/modals in the admin portal:

  • Sending Profiles >+ New Profile > Send Test Email
  • Landing Pages > + New Page > Import Site
  • Email Templates > + New Template > Import Email

and in the following browsers / OSs

  • Windows 10 v1511: Chrome, Firefox, IE11
  • Ubuntu 16.04: Firefox

My workaround for this at the moment is to zoom out the view in Chrome to see the entire modal. My monitors here at work have a 1440 x 900 resolution, so I'm guessing this might not be noticeable for users with larger resolutions. Let me know if you need further information.

bug med-priority

All 3 comments

Ah - yep. Thanks for reporting this. I've run into this issue before but I'll have to spend a bit of time investigating a possible fix. Modal layering with bootstrap is tricky business (what year is it?!) so I'll have to do some digging to see if I can get this one knocked out.

All fixed! Let me know if you run into any issues.

Thanks for all of your hard work on this awesome project! 馃憤

Was this page helpful?
0 / 5 - 0 ratings