Gopass: Deprecation warnings breaks Summon provider

[desolat]

Summary

The deprecation warning text DEPRECATION WARNING: Use gopass show is prefixed to the secret value when using the gopass Summon provider.

Steps To Reproduce

Run the gopass Summon provider with gopass 1.10.1.

Expected behavior

When using the gopass Summon provider only the secrets value is in the environment variable value.

Environment

• OS: Ubuntu 18.04
• gopass Version: 1.10.1
• Installation method: Github release

[worldofgeese]

Just encountered this today.

[AnomalRoil]

I'm not sure how the Summon provider is supposed to work, so that would be on @ckolumbus or @dominikschulz I guess.

The deprecation warning should show only if you are using gopass name/of/entry instead of gopass show name/of/entry, but afaict, the Summon provider is using our internal API directly and is not a wrapper around our CLI, so that's strange.

[ckolumbus]

@desolat I'll have a look!

[ckolumbus]

I checked gopass/v1.10.1 on go1.15.2 linux/amd64 and go1.15.3 windows/amd64 and after the build I executed the following

gopass init
gopass generate x/y
gopass-summon-provider x/y

No deprecation warnings showed. @desolat could you provide some more detailed information on how you can reproduce this error?

Are you really using the gopass-summon-provider executable (under cmd/gopass-summon-provider) which I explicitly implemented to avoid issues with the the normal gopass output? Maybe that's the reason for the problem your're facing.

[desolat]

Actually I was not using gopass-summon-provider but gopass as is being described here in the documentation: https://github.com/gopasspw/gopass/blob/master/docs/summon-provider.md. So probably that documentation is outdated.

For completeness here is an example summon call when using gopass (with stripped-down output):

$ SUMMON_PROVIDER=/usr/local/bin/gopass summon env
SECRET_ENV=DEPRECATION WARNING: Use gopass show
Password: secret value

[ckolumbus]

Ok, so I forgot to update the docs when I implemented the new summon provider command :-(. Could you please verify that it works with the gopass-summon-provider program? Then we could close this one and open a new issue to update the doc.

[desolat]

Yes, it works as expected with gopass-summon-provider. @ckolumbus You're opening the doc issue?

[ckolumbus]

You're opening the doc issue?

yes!