Google-signin: support RN 0.40.0

Created on 6 Jan 2017  路  11Comments  路  Source: react-native-google-signin/google-signin

Hi,

breaking change in RN 0.40.0 demands that the imports be redefined.

https://github.com/facebook/react-native/issues/11725

A bunch of these need to be converted. If it says #import "RCTConvert.h", it needs to change to #import

thanks,

Most helpful comment

Will there be a release for RN 0.40 anytime soon?

All 11 comments

Hi @mrKlar, why not send a PR ? This seems like an easy fix and I am sure the author would welcome the help.

He did it : https://github.com/devfd/react-native-google-signin/pull/178
I tested it and it solve the issue.

+1

I am still having problem with #import in RNGoogleSigninButtonManager.m. It might be because of incorrect search paths or something but the other errors went away after updating. Any ideas?

We may also want this docs update for 0.40: https://github.com/devfd/react-native-google-signin/pull/181

+1

Will there be a release for RN 0.40 anytime soon?

Please publish to npm

I need this too, so for now I am drawing from the forked repo. Thanks @mrKlar !

Published as v0.9.0! :tada:

Sorry for the delay everyone. @devfd added me as collaborator today, I will focus on maintaining this module up to date.

Thank you!!

Was this page helpful?
0 / 5 - 0 ratings