Google-play-music-desktop-player-unofficial-: Last song on album scrobbles twice for Last.fm

[CurlyBoy]

OS:
Windows 10

Issue Descriptions:
Whenever an album finishes, with the last song being played completely, and you start playing another song/album, the last song on the previous album scrobbles again.

Steps to Reproduce:
Listen to the last song on an album to completion. Then, start playing a new song. The last song should show being scrobbled twice.

[rjawiygvozd]

This issue still exists for me

[captainnapalm]

I've had this occur many times. It seems to scrobble the last song multiple times, even though it has completed playing. The next time it occurs I'll be sure to grab a screenshot, but I came back to work this morning and the last track that finished playing the previous day had scrobbled 10+ times.

[captainnapalm]

Has this been looked into? My playlist is complete (played a full album to completion, queue shows as empty and last track is not paused) but I'm seeing multiple scrobbles for the final song. This is just a portion of the scrobbles. They continue on the following page, probably close to 100 scrobbles for the same song in the course of an hour. This is worse now on 4.1.1 than it was on 4.0.5.

[captainnapalm]

@MarshallOfSound can you please look into this? I just deleted 3 pages worth of scrobbles for a song that hadn't played in 5 hours. the queue was finished playing, but it just kept scrobbling every minute or so until I completely quit the app.

[MarshallOfSound]

No promises but I'll see if I get a change to investigate, I personally don't use last.fm

[petuhovskiy]

This issue affected me too. It looks like the problem is in the current scrobble event trigger. Scrobble happens when playback position reaches middle of the track duration(with some other conditions), but it doesn't mean that track has been played for such a time, as user can change position anytime.
Scrobbling should be done as described on last.fm api section.

A track should only be scrobbled when the following conditions have been met:

The track must be longer than 30 seconds.
And the track has been played for at least half its duration, or for 4 minutes (whichever occurs earlier.)

It can be easily done with keeping of playback time (when the track was in playing state).
I implemented this in my fork and it works just fine.

[subliun]

Can confirm this is also an issue for me. The last track in an album usually scrobbles twice.

[mbolli]

Same for me. Happened a few times, had to delete hundreds of duplicate songs from last.fm.
@petuhovskiy would be nice if you could create a pull request for that and @MarshallOfSound to accept it.
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/compare/master...petuhovskiy:master

[fernandonito]

I confirm it too. Running on Fedora 25 x86-64

[MarshallOfSound]

@petuhovskiy Would probably accept that PR, just send it through and help everyone out 👍

[wadegbow]

Any word on the last.fm fixes getting merged with master? I've had a single song scrobble 100+ times when I wasn't using the app.

[captainnapalm]

Yeah, I've basically implemented my own workaround by just never letting the queue end, so I'll either always leave it paused, or just keep adding to the bottom of the queue so it never ends. It would be nice for this to be pushed out in the next version.

[m-ttj]

Also seeing the duplicate scrobbles for last tracks. Is there anything that needs to happen before #2317 can be merged?