Google-play-music-desktop-player-unofficial-: Provide native translations for GPMDP

[MarshallOfSound]

I recently refactored a significant portion of the app to allow for translations.

This means that all you people in non-english countries can start using GPMDP in your native language instead of English. However, I have zero faith in Google Translate so I'm looking for volunteers to translate a bunch of strings (there are about 90 of them) into the following languages.

• [x] German (@MetalMatze)
  
  
  
  • [x] #1004 - Review Needed
  
  
• [x] Russian (@LuckyKort)
  
  
  
  • [x] #1009 - Review Needed
  
  
• [x] French (@emilecantin)
  
  
  
  • [ ] #1082 - Review Needed
  
  
• [x] Spanish (@n4k1)
  
  
  
  • [ ] #1032 - Review Needed
  
  
• [x] Dutch (@Jespiee)
  
  
  
  • [x] #1007 - Review Needed
  
  
• [ ] Italian (@n0f3)
• [x] Polish (@Kun2210)
  
  
  
  • [x] #1094 - Review Needed
  
  

If you want to translate into another language, by all means :+1: just comment below and I will add it to the list.

Translation Instructions

1. Copy the en-US.json file --> here
2. Look up your language locale code here
3. Name the new JSON file {yourLocaleCode}.json
4. Translate all the values in the JSON file into your language.
5. Push to GitHub and make a Pull Request

All translation PR's will need to be submitted by one person and verified by another.

Release Process

Before each release or throughout development I will ping the volunteers here to keep the translations up to date. So please ensure that if you volunteer to translate a language you will be able to keep translating it for a while.

[berryelectronics]

I could do the german Translation. Got some spare time tomorrow.

[MarshallOfSound]

@berryelectronics Could you simply review #1004

[n4k1]

I already started spanish translation. I'll upload for review during the day

[emilecantin]

I'm about halfway through the French one, I'll upload it soon!

One question though: What do we mean by "System Default Communications"? I can't find this string anywhere in context... (I'm on Mac)

[jostrander]

In Windows this is the default sound devcie for communication.
On May 5, 2016 1:53 PM, "Emile Cantin" [email protected] wrote:

I'm about halfway through the French one, I'll upload it soon!

One question though: What do we mean by "System Default Communications"? I
can't find this string anywhere in context... (I'm on Mac)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1003#issuecomment-217225491

[n0f3]

What about Italian? I can provide translation for that language :)

[MarshallOfSound]

@n0f3 Sure, I'll add it to the list

[SolarLiner]

I went my way and created my own French translateion, without seeing that @emilecantin did one as well. I'll refrain from making my pull request in case he has his own done and if he wants to push his own.

[emilecantin]

Yeah, sorry about that, I was about 3/4 of the way through, and more pressing matters got in the way. I just completed it: #1082

@SolarLiner I believe a second set of eyes on this would be good!

[Kun2210]

@MarshallOfSound I think I can take on polish translation ;)

[jpsacheti]

I'll be working on a pt-BR translation :)

[WolfangAukang]

I can help reviewing or translating with both Spanish and Portuguese.

[Kun2210]

@MarshallOfSound OK, so it's been released, now how do I actually change the display language? I don't see such option in Settings :O

[MarshallOfSound]

@Kun2210 it should just read your system language and display the translations based on that

[Kun2210]

@MarshallOfSound Ouch, my company forces en-US on our OS.
Funny thing, GM-native elements in GUI are in the same language as Chrome - as I can set Chrome to use Polish as a UI language, I right now have GM-native strings in Polish, and those GPMDP-native are still in English, as my OS is in English.

[jostrander]

We should have an option to grab the language string from the HTML tag in
the web view. That would solve this type of problem.
On Jul 3, 2016 4:10 PM, "Konrad" [email protected] wrote:

@MarshallOfSound https://github.com/MarshallOfSound Ouch, my company
forces en-US on our OS.
Funny thing, GM-native elements in GUI are in the same language as Chrome

• as I can set Chrome to use Polish as a UI language, I right now have
  GM-native strings in Polish, and those GPMDP-native are still in English,
  as my OS is in English.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1003#issuecomment-230172712,
or mute the thread
https://github.com/notifications/unsubscribe/AAucnalak-BRqQW9LKPS-lHLwEF7upRFks5qSBc6gaJpZM4IUBtV
.

[SolarLiner]

Windows 10 set in French, however the GPMDP strings are still displayed in English. A drop down in the settings would indeed be better.

[MarshallOfSound]

@SolarLiner The french PR was not merged, I don't think it was updated so French is not available

[Kun2210]

@MarshallOfSound @jostrander Is there any way I can force GPMDP to use specific display language?

[MarshallOfSound]

Not currently

[Kun2210]

@MarshallOfSound couldn't we identify the language by the GM-native elements instead of using OS language? That way we can have consistent translations throughout the app. Not sure if this is exactly what @jostrander suggested (not sure what web-view is in this case).
In case the translation does not exist, we could failover to en-US.

[jostrander]

That's exactly what I was suggesting @Kun2210.

[laurentiuonac]

@MarshallOfSound I can help with the Romanian translation.

[RedDragonx]

I can help you with the Vietnamese translation if you want to.

[ja-som]

Hi, when will be my Slovak translation available in your app? I have v3.5.0, the JSON file is in \GPMDP_3\app-3.5.0\resources\app\build_locales, but app has still English language.

Thanks

[MarshallOfSound]

@ja-som The app detects your system language. Maybe you used the wrong language code in your PR?

[ja-som]

@MarshallOfSound thanks, Slovak language has code "sk", so I used sk-SK.

[MarshallOfSound]

@ja-som Looks like the language code is just sk

[ja-som]

@MarshallOfSound yes, you´re right, I also figured it right now, I tried to rename the JSON file only to "sk.json" (new pull request sent), the settings window is now in Slovak, but the whole menu in the tray icon is still in English, I also tried to restart the app few times.

[v-skochko]

@MarshallOfSound I want to help with Ukrainian translation!

[Animakozak]

@vskochko me too 😄

[MarshallOfSound]

@vskochko @Animakozak Just send a PR 👍

[ihiroaki]

Please, add Czech lng. :) I already have *.json file :)

[MarshallOfSound]

@ihiroaki Just end a PR 👍

[GoodWillN1]

I can verify the Czech translation once it is up (once ihiroaki does the PR).

[WolfangAukang]

Do you still need reviewing for Spanish?

[jony0008]

@MarshallOfSound I want to help with Swedish translation!

[LucianoAlbanes]

Hello everyone, I am a user of GPMDP, I speak Spanish and I would like to be able to contribute to the translation of this incredible software into Spanish. If this is possible, please give me an answer. Greetings from Argentina