Google-cloud-php: [Datastore] Support of cursor in GQL Query

[joseph1125]

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
It is impossible for now to use cursor when using GQL querying as any cursor I passed will be considered as StringValue in the request payload

Describe the solution you'd like
I would like to have a option of binding cursor in the GQLQuery

Describe alternatives you've considered
For now, I had already extended those DataStoreClient, GQLQuery and EntityMapper to run some custom logic of building payload, this is not ideal as any update of the library may break the existing code.

[jdpedrie]

Hi @joseph1125, thanks for bringing this to our attention.

I'm working on adding support for cursor bindings. I'd find it very helpful to take a look at the modifications you've made as it'll help me better understand how you as a user will be using the feature. Perhaps you would be able to fork the client and push the changes you've made so I could take a look?

Thanks!

edit: Examples of how you're using it in queries would be great too! :)

[joseph1125]

Sure, but you may have to wait for a couple days as I have to go back to the office to get those code after weekend

[joseph1125]

@jdpedrie , you can checkout the changes I had done in this commit (this should be all changes I had done as I remembered)

When I make a call, I will only need to set the bindings as following (I always use named bindings)
['cursor' => new Cursor('cursorString')]

[jdpedrie]

@joseph1125 please take a look at #1630.

[joseph1125]

@jdpedrie it looks good, seems like not a big difference from my solution

[jdpedrie]

@joseph1125 indeed! I was pleased to see we both came to approximately the same conclusion on implementation. :)

We'll try to get this change included in the next release.

[joseph1125]

Thanks a lot, man.

John Pedrie [e-mail] 於 2019年1月29日 週二 21:28寫道：

@joseph1125 https://github.com/joseph1125 indeed! I was pleased to see
we both came to approximately the same conclusion on implementation. :)

We'll try to get this change included in the next release.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googleapis/google-cloud-php/issues/1625#issuecomment-458539134,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH5VbueO_4z0iD0fGUkA2Y8IjUIpJHYNks5vIExkgaJpZM4aQYEl
.

[jdpedrie]

@joseph1125 we just released a new version with support for Cursor values in Datastore. Please take a look!