Google-cloud-node: Add Node.js 12 to the CI

Created on 23 Apr 2019  路  8Comments  路  Source: googleapis/google-cloud-node

Looks like Node.js 12 was just released! Let's get it added to the kokoro configs.

process

Most helpful comment

Node 12 is now available and tested.

All 8 comments

@bcoe please work with @jkwlui on getting this added :)

@jkwlui @JustinBeckwith I'd like to roll out the .npmrc updates too; tldr, @jkwlui please sync up with me before we start rolling this out, and we can use the bulk repo update tool.

Is the trampoline image for Node 12 available?

Friendly ping: How is progress on this going?

@bcoe I think it's probably a good time to roll this out

@JustinBeckwith I've been somewhat patiently waiting an update to V8, because there's an odd bug related to test coverage that I'm hoping is fixed up stream ... this is something we can look at prioritizing in the not too distant future.

@jkwlui is the trampoline image available? we just reference the canonical ones through nvm right?

I tried to add tests using a Node 12 trampoline image. As of 7/8, the last time I tried to start running this test, I don't think the image was available (kokoro config is here).

Node 12 is now available and tested.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sabrehagen picture sabrehagen  路  4Comments

VikramTiwari picture VikramTiwari  路  3Comments

positlabs picture positlabs  路  3Comments

dsimmons picture dsimmons  路  4Comments

pputhran picture pputhran  路  4Comments