Google-api-ruby-client: HTTPClient is no longer maintained, switch to Faraday

Created on 11 Jan 2021  路  1Comment  路  Source: googleapis/google-api-ruby-client

The generated libraries (or at least google-apis-calendar_v3) rely on HTTPClient, which hasn't had a release since 2016 and has a ton of ignored issues. Especially since it seems to re-implement the low level socket details of Net::HTTP, including establishing SSL connections, it's not really secure to be relying on something that's been abandoned.

It also uses Timeout.timeout in several places instead of using socket timeout options, which is inefficient and inherently unsafe (see https://www.mikeperham.com/2015/05/08/timeout-rubys-most-dangerous-api/ and http://blog.headius.com/2008/02/ruby-threadraise-threadkill-timeoutrb.html)

googleauth and signet already depend on Faraday, which is actively maintained. It would be great to switch over to that, even if just so as not to pull in an extra dependency, let alone an unmaintained one.

process

Most helpful comment

Yes, good call, we need to do this.

>All comments

Yes, good call, we need to do this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

asheren picture asheren  路  5Comments

jawadakram20 picture jawadakram20  路  6Comments

pacuna picture pacuna  路  5Comments

davidraj picture davidraj  路  6Comments

eric-hu picture eric-hu  路  4Comments