Gollum: Branch 5x : Dead Keys Add Keystrokes in Editor Pane

[chris2fr]

To Reproduce:

1. Configure your keyboard to use international dead keys (I use Dvorak US on my Mac)
2. Type "L'état, c'est moi" while using option-e e for the "é"

Observed Result:

L'´état, c'est moi.
Notice the extra ´ before the é

Desired Result:

L'état, c'est moi.

[dometto]

Thanks for this report. Might this be a bug in the ACE editor, rather than in gollum? Could you try reproducing this on, say, the demo editor on the ACE website?

[chris2fr]

It is not reproducible here in any case:
https://ace.c9.io/build/kitchen-sink.html
Should I look further?

[chris2fr]

Would there be a way to deactivate ACE in the 5x branch?

[chris2fr]

Hey @dometto, you were right! Simply replacing ACE-1.2.5 with ACE-1.2.9 in the source code fixed the problem!

[bartkamphorst]

@chris2fr Glad to hear you resolved this issue. Would you mind opening a PR against the 5.x branch in which ACE is updated to v.1.2.9? Would be much appreciated.

[chris2fr]

Sure, will do.

Chris Mann [phone] [email protected]
Ordiner Paris, Cultiver l'informatique www.ordiner.com

On Sun, Jan 14, 2018 at 6:30 PM, Bart Kamphorst [e-mail]
wrote:

@chris2fr https://github.com/chris2fr Glad to hear you resolved this
issue. Would you mind opening a PR against the 5.x branch in which ACE is
updated to v.1.2.9? Would be much appreciated.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gollum/gollum/issues/1275#issuecomment-357527632, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGXiZJazafENUe6wa-Ve0cg0_1U1p35ks5tKjnFgaJpZM4ROAVS
.

[bartkamphorst]

@chris2fr Any luck?

[chris2fr]

Hey,

I didn't clone.

Chris Mann [phone] [email protected]
Ordiner Paris, Cultiver l'informatique www.ordiner.com

On Mon, Feb 5, 2018 at 2:05 PM, Bart Kamphorst [e-mail]
wrote:

@chris2fr https://github.com/chris2fr Any luck?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gollum/gollum/issues/1275#issuecomment-363078994, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGXiTU17kXkTm-mUn_joD3RAJFLIUDhks5tRvyggaJpZM4ROAVS
.

[bartkamphorst]

@ProgramFan Would you mind upgrading ACE to the latest version in branch 5.x to resolve this 'dead keys' issue?

[ProgramFan]

Sorry to respond late. Would someone check if the PR resolve this issue?

[bartkamphorst]

Thanks @ProgramFan ! @chris2fr Would you mind checking if your issue with dead keys is indeed resolved with this PR?

[bartkamphorst]

@chris2fr ACE has been updated to 1.3.1 in the 5.x branch, which should resolve your issues with dead keys.