Golangci-lint: fatal error: concurrent map writes

[yaches]

Running linter in gilab ci
golangci-lint:v1.17
go 1.12

err log:
golangci.log

.golangci.yml:
```linters:
enable-all: true
disable:
# Globals are OK
- gochecknoglobals
# So are inits
- gochecknoinits
# Cant disable some of go vet checks => disable all of them
- govet
# Useless
- interfacer
# Long lines are fine
- lll
# Using "weak" primitivies is fine when they're not used for crypto
- gosec

run:
tests: false
issues-exit-code: 0
skip-dirs:
- vendor/
skip-files:
- _test.go$
```

[Helcaraxan]

I just encountered exactly the same error with an identical stack-trace.

$ golangci-lint --version
golangci-lint has version 1.17.1 built from 4ba2155 on 2019-06-10T09:07:35Z
$ go version
go version go1.12.5 darwin/amd64

[Helcaraxan]

@yaches looks like this was actually fixed 4 days ago in master (#594) and hence was not part of 1.17.1 so we should be able to close this issue. Although having a 1.17.2 patch release with this fix would be _really_ nice.

[Helcaraxan]

As suggested in #622, given this has been addressed it could be worth closing the issue. 🙂

[jirfag]

Hi, thank you for reporting, it's fixed in v1.18.0 release

[gaurav-dalvi]

I am seeing same issue on

golangci-lint version
golangci-lint has version 1.20.1 built from 849044b on 2019-10-15T19:11:27Z

[jirfag]

@gaurav-dalvi can you attach new logs/output please?

[ConorNevin]

@jirfag I'm also having the same issue intermittently on v1.23.8

error log:
golangci.log

[michaljemala]

@jirfag I am facing the same issue with v1.27.0. The crash log (attached) points to this line and indeed there is a map being written to by multiple goroutines when creating the FilenameUnadjuster.

golangci-lint_panic.log

[Helcaraxan]

Thank you for the error log @michaljemala, your analysis was indeed spot on. Have opened a PR that should address the issue in #1192.

[Helcaraxan]

I am reclosing this issue now that the latest report has been addressed. If you encounter any new concurrent map write errors please open a new issue. :slightly_smiling_face: