Gogs: Small problem with translated dates in issues or pull requests

[ogarcia]

• Gogs version: latest commit
• Git version: n/a
• Operating system: n/a
• Database (use [x]):
  
  
  
  • [ ] PostgreSQL
  
  
  • [ ] MySQL
  
  
  • [x] SQLite
  
  
• Can you reproduce the bug at https://try.gogs.io:
  
  
  
  • [x] Yes (https://try.gogs.io/testador/test/issues/1)
  
  
  • [ ] No
  
  
  • [ ] Not relevant
  
  

Description

If you set your browser in foreing language (spanish for example) you can see that dates in pull requests or issues have some bad code.

An small screen capture:

In english the HTML code is:

<span class="text grey"><a href="/testador">testador</a> commented <a href="#issue-1804"><span class="time-since" title="Wed, 01 Feb 2017 04:10:34 EST">8 minutes ago</span></a></span>

But in spanish it appear as:

<span class="text grey"><a href="/testador">testador</a> 'comentado <a href="%!(EXTRA string=issue-1804, template.HTML=<span class="time-since" title="Wed, 01 Feb 2017 04:10:34 EST">hace 8 minutos</span>)</span>

I think that must be an small problem with function that presents this piece of code.

[unknwon]

Patch has pushed to fix this issue, please test on develop branch or https://try.gogs.io.

[ogarcia]

@Unknwon Yes, but there is a ' at end of %s chain that is unnecessary.

This would be the change:

-issues.commented_at=`comentado <a href="#%s"> %s'</a>`
+issues.commented_at=`comentado <a href="#%s"> %s</a>`

(I send the change to crowdin)

[unknwon]

Approved, will update to main repo soon.