Gogs: Ability to comment on lines of code in a pull request
It would be nice to have the possibility to comment on specific lines of a code in a pull request - as it is possible in github:
Gitbucket (another github clone written in scala) has it already implemented.
hhenkel
All 44 comments
This is what I'm wanting, but take some time to clean up previous tasks. :smiley:
unknwon
on 15 Sep 2015
+1
bhchew
on 16 Sep 2015
+1
nicolai86
on 19 Sep 2015
+1
john-hu
on 14 Oct 2015
It would be great to be able to comment at the pull request level but also on individual commits.
roidelapluie
on 6 Dec 2015
+1
danielskowronski
on 29 Dec 2015
+1
wsantos
on 30 Dec 2015
+9000000000000000000000000000000000001
DarthNihilus1
on 31 Dec 2015
+1
For us this is one of the final main parts to make it basically feature complete. Having comments on code lines (and commits #796) is really a must. Would be a nice bonus for 0.10.0 ;)
mikehaertl
on 7 Mar 2016
+1
JonLundy
on 11 Mar 2016
+1
redpist
on 30 Mar 2016
+1
Chipsoid
on 13 Apr 2016
+1
shah-dhaval
on 15 Apr 2016
@Unknwon: Any update on this? We're thinking of switching from an SVN based workflow to Git + Gogs, but we'd really need this feature. We currently do code review using a very manual process (patches + e-mail), but even there we can comment on sections of code inline :) In fact, I would say most comments are inline.
Great work on Gogs btw!
estan
on 26 Apr 2016
+1 It is useful for review code in pull request
lostsnow
on 27 Apr 2016
+1
ivanguajana
on 2 May 2016
@ work We use gitlab but I'm looking for an alternative since their update and deployment process was written by crazy monkey in lack of caffeine.
But since pull request code line comments feature is missing we won't be able to switch to gogs since this is mandatory to do easy code review
theredcat
on 25 May 2016
+1
patrickreck
on 13 Jun 2016
May be possibly implemented via git-appraise ( #2210 )
strk
on 14 Jun 2016
@strk As an ops, using the git-appraise cli would be fine for me. But some of my devs would like to have a nice UI to do this.
Frontend developpers, you know....
theredcat
on 16 Jun 2016
@theredcat yes I understand that, what I'm saying is that Gogs could just add a GUI to the git-appraise tool. That way users have a choice to either use the commandline or the GUI, and peer reviews would go togheter with the code when repository is cloned.
strk
on 16 Jun 2016
@strk Thx for the clarification. This would be, indeed, a very nice approach
theredcat
on 16 Jun 2016
:+1: git-appraise with a GUI sounds like the perfect road to follow
tgy
on 16 Jun 2016
+1
stilet
on 28 Aug 2016
@strk I think git-appraise would do the job but from what I recall (not sure if it was on gitter or in an issue discussion) @Unknwon wants to keep the way gogs handles the pull request stuff. From my understanding that does result in haveing this implemented for the gogs native way of handling pull request and if someone does the git-appraise way of storing data it has to be handled differently. If the later is done I expect that a user/admin has to choose which implementation of PRs he wants to use.
hhenkel
on 29 Aug 2016
Agree, this is a must.
javydreamercsw
on 12 Oct 2016
this is a must
nfx
on 29 Dec 2016
+1
snoozemoose
on 3 Jan 2017
+9999999999
videmort
on 11 Jan 2017
+1
MehSha
on 6 Feb 2017
STOP WITH '+1'
In many cases, especially on popular projects, the result is a long thread full of emoji and not much content, which makes it difficult to have a discussion. With reactions, you can now reduce the noise in these threads.
https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments
USE THAT!
I, and many others, are subscribed here for updates. Your '+1' is just making a mess.
eigan
on 6 Feb 2017
Planned after https://github.com/gogits/gogs/issues/2109
unknwon
on 8 Apr 2017
Hi! Any updates on this issue?
federicobond
on 15 Aug 2017
Hi, any updates to this request?
OsmeDiegoGH
on 22 Sep 2017
Any updates now? It's almost 2018, and this issue was opened in 2015.
kdrag0n
on 18 Dec 2017
Hello - Will this feature be implemented at all?
kathiouchka
on 8 Feb 2018
Choose GitLab if you need feature-rich Git hosting! Seriously! Or just pay GitHub, it's just $7/month with unlimited private repositories. Or fork it, and do whatever you want!
Programmers, create the world with your own hands! Only managers ask features and just wait every single day!
unknwon
on 4 Mar 2018
but a maintained Gogs with code comments is so much better than GitLab
adventurist
on 9 Apr 2018
What needs to be done so that this can become a reality? I see that there may be a dependency on #2109, but I don't see any progress on that issue.
forestbelton
on 27 Nov 2018
@forestbelton at the risk of getting this comment deleted, gitea has comments available in the 1.6.0 release
ptman
on 27 Nov 2018
Are you going to update it?
minias
on 6 Nov 2019
I'm interested into this. Is anyone already wordking on it ?
lcalaresu
on 22 Dec 2019
Any updates on this major missing feature in Gogs? 👍
christopherstock
on 28 Mar 2020
i start made this feature, but my progress is slow
my progress and discussion will be here for public https://discuss.gogs.io/t/line-number-commenting-on-pull-request/2668/3
branch here https://github.com/ivanbogomoloff/gogs/commits/feature/1644/ability-comment-pr
nowaday i implemented:
- simple ui on html+js (add, delete, markdown render)
- http post endpoint with send comment data and response rendered code comment
but now it very raw
i plan finish this feature in very very simple implementation to august, i hope do it
ivanbogomoloff
on 14 Jun 2020
Related issues
JonLundy
·
3Comments
r0bc94
·
3Comments
rugk
·
3Comments
ceeji
·
3Comments
zoh48gz04
·
3Comments
Most helpful comment
STOP WITH '+1'
https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments
USE THAT!
I, and many others, are subscribed here for updates. Your '+1' is just making a mess.