Godot: Random scene files are starting mask/layer as 2^31 and not zero
Godot version:
3.2.2 stable
OS/device including version:
linux mint 64bit
Issue description:
I was trying to find out which of my nodes had a certain layer/mask bit set (would be nice if this was a feature in the ide :) ), but when I searched my tscn files I noticed some of my nodes, instead of the collision_mask or collision_layer being 2^x they were 2^31+2^x
In these, all bits off are 2147483648 and not 0.
As screenshot below.
I appreciate not a giant bug in the scheme of things, but it might be indicative of a larger fault/overflow fault somewhere.
In addition, can somebody tell me if it's safe to edit these .tscn files and change them all to their normal numbers?
Steps to reproduce:
I have no idea
chucklepie
All 20 comments
note, when I modify these bits, e.g. turn them all off, they never reset back to zero, as if something is holding these nodes to a particular value or setting the bit with a shift or similar maths operation rather than setting as an actual number after each bit is toggled on / off?
chucklepie
on 15 Aug 2020
For your reference, here is the entire file of one of these, and the physics layer definition. Nothing out of the ordinary..
[gd_scene load_steps=4 format=2]
[ext_resource path="res://assets/sprites/invisible_blocker.png" type="Texture" id=1]
[ext_resource path="res://entities/static/InvisibleBlocker.gd" type="Script" id=2]
[sub_resource type="RectangleShape2D" id=1]
extents = Vector2( 32, 27 )
[node name="InvisibleBlocker" type="StaticBody2D"]
z_index = 5
collision_layer = 2147483664
collision_mask = 8
script = ExtResource( 2 )
[node name="Sprite" type="Sprite" parent="."]
position = Vector2( 0, 6 )
scale = Vector2( 2, 1.6 )
texture = ExtResource( 1 )
[node name="CollisionShape2D" type="CollisionShape2D" parent="."]
position = Vector2( 0, 6 )
shape = SubResource( 1 )
[layer_names]
2d_physics/layer_1="player"
2d_physics/layer_2="environment"
2d_physics/layer_3="foreground"
2d_physics/layer_4="enemy"
2d_physics/layer_5="invisible_blocker01"
2d_physics/layer_6="enemy_blocked_by_tile"
2d_physics/layer_7="enemy_weapon"
2d_physics/layer_8="player_spawn_centre"
I can confirm this happened to me couple days ago. But i can't make minimal reproduce. Really strange bug. The work around is to make another scene similar to this and the problem is gone. It is only happens in collision mask.
fian46
on 15 Aug 2020
Not for me, it's both:
[node name="ProjectileDetection" type="Area2D" parent="."]
collision_layer = 0
collision_mask = 2147483648
chucklepie
on 15 Aug 2020
This is probably due to a member variable being left uninitialized (which is undefined behavior in C++). See also https://github.com/godotengine/godot/pull/39695.
Calinou
on 15 Aug 2020
Maybe a better solution is every time a bit is modified, create the mask
value again. I can only presume that currently every bit does a bitwise
operation on the current value and changing to not doing this will fix it?
On Sat, 15 Aug 2020, 15:21 Hugo Locurcio, notifications@github.com wrote:
This is probably due to a member variable being left uninitialized (which
is undefined behavior in C++).—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/41281#issuecomment-674404263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRO7ECB4USKC43DMVXLSA2KWRANCNFSM4QAHSWZA
.
chucklepie
on 15 Aug 2020
That could well be correct.
2147483664 in decimal is 1000 0000 0000 0000 0000 0000 0001 0000 in binary. So the 4th bit (or 5th bit if you read from 1) is set for the layer, matching the display in the IDE, and also bit 31 (no idea why but it might be set on purpose, you'd have to check the source).
The mask is 8 which is 1000 in binary which matches the mask in the IDE.
If it is a bug having bit 31 set, it could be a wrong signed / unsigned cast or similar.
lawnjelly
on 15 Aug 2020
I don't think so. You can reset all the bits to zero and it still keeps it
at 2^31
There's no reason, other than a numeric overflow (or as stated above an
unallocated number) causing it....
On Sat, 15 Aug 2020, 17:14 lawnjelly, notifications@github.com wrote:
That could well be correct.
2147483648 in decimal is 1000 0000 0000 0000 0000 0000 0001 0000 in
binary. So the 4th bit (or 5th bit if you read from 1) is set for the
layer, matching the display in the IDE, and also bit 31 (no idea why but it
might be set on purpose).The mask is 8 which is 1000 in binary which matches the mask in the IDE.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/41281#issuecomment-674418109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRJNNG3LPMRKVYU36H3SA2X7DANCNFSM4QAHSWZA
.
chucklepie
on 15 Aug 2020
I had a quick look and I can't see anything obvious that is using bit 31, so it may well be a bug. It will probably need being able to reproduce it to debug.
It seems unlikely to be directly an uninitialized value, given that in the example the correct bit was set (4), but bit 31 was set as well (that seems unlikely to occur by chance).
lawnjelly
on 15 Aug 2020
But it's
01111111111111111111111111111111
In binary, so I can only presume its a shift error.
If the collision values were set on every click I expect it'll be OK, so
not seeing the code I can presume there's a bitwise operation going on in
every click to mimic calling the set bit method?
On Sat, 15 Aug 2020, 18:38 lawnjelly, notifications@github.com wrote:
I had a quick look and I can't see anything obvious that is using bit 31,
so it may well be a bug. It will probably need being able to reproduce it
to debug.It seems unlikely to be directly an uninitialized value, given that in the
example the correct bit was set (4), but bit 31 was set as well (that seems
unlikely to occur by chance).—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/41281#issuecomment-674427785,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRJQIUPZWGSPJBJ3PWLSA3B23ANCNFSM4QAHSWZA
.
chucklepie
on 15 Aug 2020
Maybe this is caused due this errors:
modules/bullet/collision_object_bullet.cpp:307:15: runtime error: implicit conversion from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type 'int' changed the value to -1 (32-bit, signed)
modules/bullet/area_bullet.cpp:62:15: runtime error: implicit conversion from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type 'int' changed the value to -1 (32-bit, signed)
modules/bullet/collision_object_bullet.cpp:104:15: runtime error: implicit conversion from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type 'int' changed the value to -1 (32-bit, signed)
modules/bullet/rigid_body_bullet.cpp:248:15: runtime error: implicit conversion from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type 'int' changed the value to -1 (32-bit, signed)
qarmin
on 15 Aug 2020
In these, all bits off are 2147483648 and not 0.
The IDE only shows 20 bits. Within code, 32 bits can be used for creating collision_layers and collision_masks. So although none of the bits are selected in the IDE, there are another 12 bits that could be set and not displayed. In this case, the 32nd bit is selected, but not displayed.
note, when I modify these bits, e.g. turn them all off, they never reset back to zero, as if something is holding these nodes to a particular value or setting the bit with a shift or similar maths operation rather than setting as an actual number after each bit is toggled on / off?
If you want to clear all the bits, use the reset button ↺ to set it to the default: 1. Then deselect the first layer/mask. If you now save the scene you will see it set to zero in the .tscn file.
madmiraal
on 15 Sep 2020
Please read my post fully.
When you reset them to zero they are still stored as 2^31. I went to the
expense of detailing all this in great detail and showing screen shots.
This is not a bigger number of hidden bits, it's treating a very large
number as zero.
On top of this I mentioned it is also breaking collision detection.
On Tue, 15 Sep 2020, 17:13 Marcel Admiraal, notifications@github.com
wrote:
In these, all bits off are 2147483648 and not 0.
The IDE only shows 20 bits. Within code, 32 bits can be used for creating
collision_layers and collision_masks. So although none of the bits are
selected in the IDE, there are another 12 bits that could be set and not
displayed. In this case, the 32nd bit is selected, but not displayed.note, when I modify these bits, e.g. turn them all off, they never reset
back to zero, as if something is holding these nodes to a particular value
or setting the bit with a shift or similar maths operation rather than
setting as an actual number after each bit is toggled on / off?If you want to clear all the bits, use the reset button ↺ to set it to the
default: 1. Then deselect the first layer/mask. If you now save the scene
you will see it set to zero in the .tscn file.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/41281#issuecomment-692820094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRO6JGR75OJPHYH5UHTSF6HDLANCNFSM4QAHSWZA
.
chucklepie
on 15 Sep 2020
The IDE only shows 20 bits. Within code, 32 bits can be used for creating collision_layers and collision_masks. So although none of the bits are selected in the IDE,
Why this discrepancy? I expect many users will be caught out by this, current bug notwithstanding.
Zireael07
on 15 Sep 2020
Maybe make your comment a new request, otherwise it might hide the actual
fault of the mask values corrupting itself, never resetting to zero and the
collision box results turning bad...
On Tue, 15 Sep 2020, 18:12 Zireael07, notifications@github.com wrote:
The IDE only shows 20 bits. Within code, 32 bits can be used for creating
collision_layers and collision_masks. So although none of the bits are
selected in the IDE,Why this discrepancy? I expect many users will be caught out by this,
current bug notwithstanding.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/41281#issuecomment-692852459,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRPWPCWWCQAYMBUUBILSF6N7RANCNFSM4QAHSWZA
.
chucklepie
on 15 Sep 2020
@chucklepie Using your test project: https://gitlab.com/chucklepie-productions/games/testarea2d.git and following my instructions:
If you want to clear all the bits, use the reset button ↺ to set it to the default: 1. Then deselect the first layer/mask. If you now save the scene you will see it set to zero in the .tscn file.
The area2d.tscn goes from this:
...
[node name="Area1" type="Area2D" parent="."]
position = Vector2( 65, 196 )
collision_layer = 2147483648
collision_mask = 0
[node name="A1Collision" type="CollisionShape2D" parent="Area1"]
modulate = Color( 1, 0.717647, 0.0980392, 1 )
position = Vector2( 96, -84 )
shape = SubResource( 1 )
[node name="Area2" type="Area2D" parent="."]
position = Vector2( 228, 205 )
collision_layer = 0
collision_mask = 0
[node name="A2Collision" type="CollisionShape2D" parent="Area2"]
position = Vector2( 4, -6 )
shape = SubResource( 2 )
[node name="Area3" type="Area2D" parent="."]
position = Vector2( 146, 66 )
collision_layer = 0
collision_mask = 2147483648
...
to this:
...
[node name="Area1" type="Area2D" parent="."]
position = Vector2( 65, 196 )
collision_layer = 0
collision_mask = 0
[node name="A1Collision" type="CollisionShape2D" parent="Area1"]
modulate = Color( 1, 0.717647, 0.0980392, 1 )
position = Vector2( 96, -84 )
shape = SubResource( 1 )
[node name="Area2" type="Area2D" parent="."]
position = Vector2( 228, 205 )
collision_layer = 0
collision_mask = 0
[node name="A2Collision" type="CollisionShape2D" parent="Area2"]
position = Vector2( -6, -14 )
shape = SubResource( 2 )
[node name="Area3" type="Area2D" parent="."]
position = Vector2( 146, 66 )
collision_layer = 0
collision_mask = 0
...
All the collision_layers and collision_masks are now zero. Are you saying you're having a different experience?
madmiraal
on 15 Sep 2020
Yes. I had to manually edit the files and set to zero.
When I set to zero on the editor, the value was 2 billion (2^31 I think).
However all the bits were showing ok in the editor.
Ie it was treating this big number as zero.
My conclusion, can somebody confirm? When you set a bit on the ide it
doesn't recalculate the mask value but performs a bit operation instead, so
the value will never really be set?
I can get my tscn files out of git and upload somewhere if required, maybe
it's the project corrupted?
On Tue, 15 Sep 2020, 18:18 Marcel Admiraal, notifications@github.com
wrote:
@chucklepie https://github.com/chucklepie Using your test project:
https://gitlab.com/chucklepie-productions/games/testarea2d.git and
following my instructions:If you want to clear all the bits, use the reset button ↺ to set it to the
default: 1. Then deselect the first layer/mask. If you now save the scene
you will see it set to zero in the .tscn file.The area2d.tscn goes from this:
...
[node name="Area1" type="Area2D" parent="."]
position = Vector2( 65, 196 )
collision_layer = 2147483648
collision_mask = 0
[node name="A1Collision" type="CollisionShape2D" parent="Area1"]
modulate = Color( 1, 0.717647, 0.0980392, 1 )
position = Vector2( 96, -84 )
shape = SubResource( 1 )
[node name="Area2" type="Area2D" parent="."]
position = Vector2( 228, 205 )
collision_layer = 0
collision_mask = 0
[node name="A2Collision" type="CollisionShape2D" parent="Area2"]
position = Vector2( 4, -6 )
shape = SubResource( 2 )
[node name="Area3" type="Area2D" parent="."]
position = Vector2( 146, 66 )
collision_layer = 0
collision_mask = 2147483648
...
to this:
...
[node name="Area1" type="Area2D" parent="."]
position = Vector2( 65, 196 )
collision_layer = 0
collision_mask = 0
[node name="A1Collision" type="CollisionShape2D" parent="Area1"]
modulate = Color( 1, 0.717647, 0.0980392, 1 )
position = Vector2( 96, -84 )
shape = SubResource( 1 )
[node name="Area2" type="Area2D" parent="."]
position = Vector2( 228, 205 )
collision_layer = 0
collision_mask = 0
[node name="A2Collision" type="CollisionShape2D" parent="Area2"]
position = Vector2( -6, -14 )
shape = SubResource( 2 )
[node name="Area3" type="Area2D" parent="."]
position = Vector2( 146, 66 )
collision_layer = 0
collision_mask = 0
...
All the collision_layers and collision_masks are now zero. Are you saying
you're having a different experience?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/41281#issuecomment-692855792,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRI4ZNIZET6U3I5FAS3SF6OXVANCNFSM4QAHSWZA
.
chucklepie
on 15 Sep 2020
@chucklepie If you want to set the collision_mask or collision_layer to zero you have to use the reset button ↺ to first set it to the default: 1. Otherwise, as you suggest, just clicking on the the individual squares or checking/unchecking the named layers will only change a single bit. The other bits (visible or not) will not be changed. In your case the 32nd bit is set and invisible, and it will remain set until the reset button ↺ is used.
The question of why or how it got set to this value is a separate question, and is the basis of this issue.
madmiraal
on 15 Sep 2020
@TheOrganicRobot has found the way to reproduce the issue:
After several hours of trying to solve the issue, I believe it came from the Collision section of an Area2D node. When opening the Collision section, there are there 20 boxes for the Layer and 20 for the Mask, and also the containing darker box containing all 20 of the layer boxes. The issue is that clicking anywhere within the darker container that is NOT on one of the 20 boxes still has some sort of effect regarding the decided collision layers without triggering one of the 20 boxes to be highlighted. This can be seen by the circular "revert" arrow that shows up, as well as in the Output that displays "Set collision_layer."
madmiraal
on 12 Oct 2020
Good detective work, thanks for the effort on finding and fixing this.
I feel vindicated with all the doubters 😉
On Mon, 12 Oct 2020, 08:38 Marcel Admiraal, notifications@github.com
wrote:
@TheOrganicRobot https://github.com/TheOrganicRobot has found the way
to reproduce
https://github.com/godotengine/godot/issues/42709#issue-718775237 the
issue:After several hours of trying to solve the issue, I believe it came from
the Collision section of an Area2D node. When opening the Collision
section, there are there 20 boxes for the Layer and 20 for the Mask, and
also the containing darker box containing all 20 of the layer boxes. The
issue is that clicking anywhere within the darker container that is NOT on
one of the 20 boxes still has some sort of effect regarding the decided
collision layers without triggering one of the 20 boxes to be highlighted.
This can be seen by the circular "revert" arrow that shows up, as well as
in the Output that displays "Set collision_layer."—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/41281#issuecomment-706938136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRNE7YKKR5VIXFM5TFTSKKXAPANCNFSM4QAHSWZA
.
chucklepie
on 12 Oct 2020
Related issues
alelepd
·
187Comments
karroffel
·
144Comments
willnationsdev
·
93Comments
Calinou
·
219Comments
ghost
·
117Comments
Most helpful comment
@TheOrganicRobot has found the way to reproduce the issue: